appModule for VS Code to disable browse mode by default#9828
Merged
Conversation
feerrenrut
approved these changes
Jul 1, 2019
Contributor
|
@LeonarddeR Thanks, now I can delete the appModule I wrote for this. By the way, I think as it is now, that browse mode is also not triggered for content that is explicitly set to have a document role. For example, in some parts of VS Code it is nice to have browse mode by default, documentation/release notes/extension pages etc which are rendered as HTML documents. |
Collaborator
Author
|
This is true. Do you have any suggestions on how to do this?
May be we should do it just differently than on the app module level
|
LeonarddeR
added a commit
that referenced
this pull request
Mar 31, 2020
This reverts commit 480950f.
feerrenrut
pushed a commit
that referenced
this pull request
Apr 30, 2020
This reverts commit 480950f. Removes the no-longer needed code.py appmodule. Follow up of #10903 (removed the no-longer needed code - insiders.py appmodule) Reverts #9828 (creating the code.py appmodule) Changes to VS Code fixing #10888 have now made it stable. Therefore, remove the appModule which worked around these issues. Note: Users can continue to force disable browse mode by default using a profile automatically triggered when entering vsCode that unchecks "Enable browse mode on page load" on the browse mode settings panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Visual Studio Code's primary goal is editing source code. However, as it is an electron app, browse mode is enabled by default.
Description of how this pull request fixes the issue:
Browse mode is now disabled by default on the appModule level.
Testing performed:
Tested that browse mode stays off by default in VS Code.
Known issues with pull request:
None
Change log entry:
Cc @bramd