Update Liblouis to version 3.5.0#7839
Merged
Merged
Conversation
added 3 commits
December 7, 2017 17:19
* Update liblouis to 3.4.0 * Add new Lithuanian 6 dot braille table and rename the existing Lithuanian table to Lithuanian 8 dot in the interface
… of the actual tables list
Contributor
|
Hi, let’s wait for 3.4.1 (next week) before incubating it. Thanks.
From: Leonard de Ruijter [mailto:notifications@github.com]
Sent: Thursday, December 7, 2017 11:19 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [nvaccess/nvda] Update Liblouis to version 3.4 (#7839)
Link to issue number:
Supersedes #7822 <#7822> .
Follow-up of #7702 <#7702>
Closes #7301 <#7301>
Fixes #7693 <#7693> , and possibly other issues
Fixes #7526 <#7526>
Description of this pull request:
First and foremost, this updates the Liblouis braille translator to version 3.4, which is the most recent version.
In #7702 <#7702> , we introduced a hidden config parameter to toggle the use of Liblouis multipass vs. pass1only. In that pr, pass1only was still enabled, although you could disable it by changing a hidden config parameter. E.g.:
import config; config.conf["braille"]["outputPass1Only"]=False
This pr also changes the default for outputPass1Only to false, effectively disabling pass1only for everyone except for the users who explicitly decide to enable pass1only by hand again.
Rationale for swithcing off pass1only
See the following snippet from the liblouis 3.4 release announcement/news:
* output positions (outputPos) are now calculated based on input positions (inputPos) thanks to @bertfrees <https://github.com/bertfrees> . This avoids a whole class of bugs that previously plagued the output positions. This fix also obviates the need for the pass1Only flag.
The pass1Only flag has been deprecated. Its use should be avoided, and it will be completely removed from the code in the next version of Liblouis. When using the pass1Only flag in this release you will get a warning.
Change log entry:
* New features
* New braille translation table: Lithuanian 8 dot
* Changes
* Updated liblouis braille translator to 3.4.0.
* Bug fixes
* Fixed malformed braille output for several braille tables, including capital signs in 8 dot contracted Danish braille. (#7526 <#7526> , #7693 <#7693> )
…_____
You can view, comment on, or merge this pull request online at:
#7839
Commit Summary
* * Noi longer use liblouis pass1only by default
* Added unit test for braille table existence
* Added a unit test to test whether all renamed braille tables are part of the actual tables list
File Changes
* M include/liblouis <https://github.com/nvaccess/nvda/pull/7839/files#diff-0> (2)
* M readme.md <https://github.com/nvaccess/nvda/pull/7839/files#diff-1> (2)
* M source/brailleTables.py <https://github.com/nvaccess/nvda/pull/7839/files#diff-2> (5)
* M source/config/configSpec.py <https://github.com/nvaccess/nvda/pull/7839/files#diff-3> (2)
* A tests/unit/test_brailleTables.py <https://github.com/nvaccess/nvda/pull/7839/files#diff-4> (31)
Patch Links:
* https://github.com/nvaccess/nvda/pull/7839.patch
* https://github.com/nvaccess/nvda/pull/7839.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#7839> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkJ0w6Y6m7qaKNzfvwRC38cJRe751ks5s-OLsgaJpZM4Q6slE> .
|
Collaborator
Author
|
@josephsl commented on 8 dec. 2017 08:22 CET:
What is your source regarding this potential 3.4.1 release? There is no milestone for this release. |
Contributor
|
Hi, Liblouis mailing list. Thanks.
From: Leonard de Ruijter [mailto:notifications@github.com]
Sent: Monday, December 11, 2017 12:21 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Update Liblouis to version 3.4 (#7839)
<https://github.com/josephsl> @josephsl commented on 8 dec. 2017 08:22 CET <#7839 (comment)> :
Hi, let’s wait for 3.4.1 (next week) before incubating it. Thanks.
What is your source regarding this potential 3.4.1 release? There is no milestone for this release.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#7839 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkLLOekhHUuNC8aL55gTpCesPspV5ks5s_Y6sgaJpZM4Q6slE> .
|
Collaborator
Author
|
Here is the most recent update for the bugfix release (3.4.1). |
Collaborator
Author
|
@josephsl: Curious to know your opinion about the current state of Liblouis. It seems that development is heavily delayed. I don't think it is a good idea to force Liblouis 3.4.1 upon users of NVDA 2017.1. I could base this pr on Liblouis 3.4.1 pre 1, but I don't think that doesn't make any sense either. |
Contributor
|
Hi, agreed. I motion that we come back to it once 2018.1 hits the air. Thanks.
From: Leonard de Ruijter [mailto:notifications@github.com]
Sent: Saturday, February 3, 2018 5:59 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Update Liblouis to version 3.4.1 (#7839)
@josephsl <https://github.com/josephsl> : Curious to know your opinion about the current state of Liblouis. It seems that development is heavily delayed.
I don't think it is a good idea to force Liblouis 3.4.1 upon users of NVDA 2017.1. I could base this pr on Liblouis 3.4.1 pre 1, but I don't think that doesn't make any sense either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#7839 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkPevBP6MJ5GJjOTokqnAdQ7siWwcks5tRGY9gaJpZM4Q6slE> .
|
|
The planned 3.4.1 release was cancelled because it's almost time for the next regular release (3 weeks). However it would still be useful if you guys could test the v3.4.1-pre1 tag. |
Collaborator
Author
|
@bertfrees commented on 12 feb. 2018 12:27 CET:
I agree this could be beneficial. @michaelDCurran: How about incubating this pr to allow some testing to be done, and than update the pr to 3.5 when that is out? |
feerrenrut
reviewed
Feb 14, 2018
| * [IAccessible2](http://www.linuxfoundation.org/collaborate/workgroups/accessibility/iaccessible2), version 1.3 | ||
| * [ConfigObj](http://www.voidspace.org.uk/python/configobj.html), version 4.6.0 | ||
| * [liblouis](http://www.liblouis.org/), version 3.3.0 | ||
| * [liblouis](http://www.liblouis.org/), version 3.4.1 |
Contributor
There was a problem hiding this comment.
Might want to update this to 3.4.1Pre1
added 2 commits
February 14, 2018 08:19
Collaborator
Author
|
Liblouis 3.5 will most certainly drop support for pass1only completely, see liblouis/liblouis#511. cc @BueVest @michaelDCurran: with this in mind, we could consider removing the outputPass1Only what's new entry for 2018.1, since it probably will only survive that version. This proposal does not conflict with the translation freeze. |
Contributor
|
@LeonarddeR The french tables 'fr-fr-g1.utb', 'fr-fr-g2.ctb', 'fr-ca-g1.utb' and 'fr-ca-g2.ctb' have been removed. Thanks |
Collaborator
Author
|
@michaelDCurran: This is now fully based on Liblouis 3.5, so your review would be greatly appreciated. |
michaelDCurran
approved these changes
Mar 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Supersedes #7822.
Follow-up of #7702
Closes #7301
Fixes #7693, and possibly other issues
Fixes #7526
Closes #7847
Description of this pull request:
First and foremost, this updates the Liblouis braille translator to version 3.5, which is the most recent version. This includes a new Lithuanian 8 dot table, a Mongolian grade 2 table and a Ukrainian table.
In #7702, we introduced a hidden config parameter to toggle the use of Liblouis multipass vs. pass1only. In that pr, pass1only was still enabled, although you could disable it by changing a hidden config parameter. E.g.:
import config; config.conf["braille"]["outputPass1Only"]=FalseThis pr removes this flag altogether, as pass1only has been removed from liblouis.
This also adds two unit tests for the brailleTables module:
Testing performed
Change log entry:
New features
Changes
Bug fixes
Changes for developers