Buevest remove pass1 only#511
Conversation
|
Seems to fail because of a format error, possibly in lou_translateString.c. How can I find the exact error? |
|
It's OK, we can fix that while merging. As long as the 4 other builds pass, it's fine. |
|
I would have changed "warning: pass1Only mode has been deprecated" to "warning: pass1Only mode is not supported anymore". And I also notice now that lou_translateString.c didn't have such a warning, maybe it should be added. |
|
Thank you very much. However, it would be nice if I could also check and correct these errors myself. I am bound to make this type of error every now and then, because it is difficult for me to be sure about things as indentation and extra tabs and spaces.
|
|
To be honest I'm not very happy with the way we have set up the travis test to check the quality of the source code. I've reopened #438. |
|
Ok, I will re-enable the warning for both functions.
|
|
@BueVest Thanks for fixing the warnings. The formatting issues are not real errors, you shouldn't care too much about it. The check is just there to remind the person who does the merge to fix the formatting first. You could do it yourself by running |
|
Is there anything else I need to do here before we merge? |
|
@BueVest No everything is fine, it will be included in 3.5. Thanks! |
9cdfe17 to
7d07497
Compare
Resolves #462.