Skip to content

Buevest remove pass1 only#511

Merged
bertfrees merged 5 commits into
liblouis:masterfrom
BueVest:buevest_remove_pass1Only
Feb 23, 2018
Merged

Buevest remove pass1 only#511
bertfrees merged 5 commits into
liblouis:masterfrom
BueVest:buevest_remove_pass1Only

Conversation

@BueVest

@BueVest BueVest commented Feb 14, 2018

Copy link
Copy Markdown
Contributor

Resolves #462.

@BueVest

BueVest commented Feb 15, 2018

Copy link
Copy Markdown
Contributor Author

Seems to fail because of a format error, possibly in lou_translateString.c. How can I find the exact error?

@bertfrees

Copy link
Copy Markdown
Member

It's OK, we can fix that while merging. As long as the 4 other builds pass, it's fine.

@bertfrees

Copy link
Copy Markdown
Member

I would have changed "warning: pass1Only mode has been deprecated" to "warning: pass1Only mode is not supported anymore". And I also notice now that lou_translateString.c didn't have such a warning, maybe it should be added.

@BueVest

BueVest commented Feb 16, 2018 via email

Copy link
Copy Markdown
Contributor Author

@egli

egli commented Feb 16, 2018

Copy link
Copy Markdown
Member

To be honest I'm not very happy with the way we have set up the travis test to check the quality of the source code. I've reopened #438.

@BueVest

BueVest commented Feb 16, 2018 via email

Copy link
Copy Markdown
Contributor Author

@bertfrees

Copy link
Copy Markdown
Member

@BueVest Thanks for fixing the warnings.

The formatting issues are not real errors, you shouldn't care too much about it. The check is just there to remind the person who does the merge to fix the formatting first.

You could do it yourself by running make format-sources and committing the changes. You need to have clang-format installed for this. However the issue is that apparently newer versions of clang-format behave slightly different.

@bertfrees bertfrees added this to the 3.5 milestone Feb 19, 2018
@BueVest

BueVest commented Feb 23, 2018

Copy link
Copy Markdown
Contributor Author

Is there anything else I need to do here before we merge?
Turns out that Clang is not that easy to install on Ubuntu on Windows, so I probably can't fix the formating, at least not just now.

@bertfrees

Copy link
Copy Markdown
Member

@BueVest No everything is fine, it will be included in 3.5. Thanks!

@bertfrees bertfrees self-assigned this Feb 23, 2018
@bertfrees bertfrees force-pushed the buevest_remove_pass1Only branch from 9cdfe17 to 7d07497 Compare February 23, 2018 21:21
@bertfrees bertfrees merged commit 7d07497 into liblouis:master Feb 23, 2018
@BueVest BueVest deleted the buevest_remove_pass1Only branch September 1, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants