No longer use liblouis pass1only by default#7822
Conversation
|
Is there a release schedule, giving an estimate for when liblouis 3.5 will be available? |
|
Apologies if I've missed something obvious, could you please clarify what the following means?
We are currently using Liblouis 3.3 I believe, do these bugs not affect us? Why don't we have to wait for Liblouis 3.4? |
|
Hi, 3.5.0 is scheduled for March 2018. @LeonarddeR, could you mind using a base 3.4.0 branch where we can incorporate Liblouis 3.4.0 changes (including new tables)? Thanks.
|
|
@feerrenrut commented on 5 dec. 2017 01:47 CET:
I think there are various reasons why this particular pr can be incorporated before Liblouis 3.4 is out:
@josephsl: I assume liblouis 3.4 is scheduled for release before NVDA 2018.1 will be in feature freeze? If so, I can change this pr to be a Liblouis 3.4 incorporation pr as soon as liblouis 3.4 is there. |
|
Hi, Liblouis 3.4 is out now, so please go ahead and make it a part of 3.4 PR branch. I’ll ask Lithuanian translator if the new six dot table is production ready, and if so, we can write something about that. Thanks.
From: Leonard de Ruijter [mailto:notifications@github.com]
Sent: Monday, December 4, 2017 11:03 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] No longer use liblouis pass1only by default (#7822)
<https://github.com/feerrenrut> @feerrenrut commented on 5 dec. 2017 01:47 CET <#7822 (comment)> :
We are currently using Liblouis 3.3 I believe, do these bugs not affect us? Why don't we have to wait for Liblouis 3.4?
I think there are various reasons why this particular pr can be incorporated before Liblouis 3.4 is out:
1. Other screen readers, including JAWS, already use Liblouis in production without pass1only
2. Using pass1only causes major problems for users of several tables as mentioned above.
3. The particular liblouis commit I mentioned suggests that currently, pass1only is also broken somehow.
@josephsl <https://github.com/josephsl> : I assume liblouis 3.4 is scheduled for release before NVDA 2018.1 will be in feature freeze? If so, I can change this pr to be a Liblouis 3.4 incorporation pr as soon as liblouis 3.4 is there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#7822 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkL1PpF7MAV8529z9qfKxZ4ctGSYmks5s9OqygaJpZM4Q0wZ9> .
|
|
That's fine with me, I will close this pr. |
|
Hi, I think it’d be better to keep it alive for 2018.1 at least so folks can try it out for the next few weeks. Thanks.
From: Leonard de Ruijter [mailto:notifications@github.com]
Sent: Monday, December 4, 2017 11:10 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] No longer use liblouis pass1only by default (#7822)
That's fine with me, I will close this pr.
@jospehsl: Do you think we should remove the hidden config parameter altogether, or keep it until 3.5 is out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#7822 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkEKBG35rUfwMrsmTjAhcVFgqi5Smks5s9OxggaJpZM4Q0wZ9> .
|
Link to issue number:
Follow-up of #7702
Closes #7301
Fixes #7693, and possibly other issues
fixes #7526
Description of this pull request:
In #7702, we introduced a hidden config parameter to toggle the use of Liblouis multipass vs. pass1only. In that pr, pass1only was still enabled, although you could disable it by changing a hidden config parameter. E.g.:
import config; config.conf["braille"]["outputPass1Only"]=FalseThis pr changes the default for outputPass1Only to false, effectively disabling pass1only for everyone except for the users who explicitly decide to enable pass1only by hand again.
Though this is a one liner change, this should not go straight to master as it could have major effect on how people experience braille output for certain tables.
Rationale
According to commit liblouis/liblouis@ac59139 , output position issues have been fixed in liblouis master, this commit will be in Liblouis 3.4. Note that other screen readers do not use pass1only either, so we don't have to wait for Liblouis 3.4 in order to have this merged.
Also note that liblouis/liblouis#445 states that pass1only will be deprecated in liblouis 3.4 and removed in liblouis 3.5. Thus, as soon as liblouis 3.5 is there and we use that in NVDA, the config parameter should be removed altogether. Cc @josephsl
Change log entry: