Update the FTDI interface to be 64-bit compatible#19105
Merged
Conversation
Member
Author
|
@michaelDCurran note that I want to send this for one last round of testing once it's reviewed. MiscDeps also needs to be updated once nvaccess/nvda-misc-deps#46 is merged. |
Co-authored-by: Michael Curran <mick@nvaccess.org>
seanbudd
pushed a commit
that referenced
this pull request
Nov 30, 2025
follow-up #18480 follow-up #19105 Follow-up #19196 Summary of the issue: Commit references in projectDocs/dev/createDevEnvironment.md were out of date. There were also references to nvda_dmp and the old ftd2xx.py. Description of user facing changes: None Description of developer facing changes: Description of runtime submodules now more accurately reflects reality. Description of development approach: Updated commit references and removed outdated items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19028
Summary of the issue:
Papenmeier braille displays don't work with 64-bit NVDA.
Description of user facing changes:
Papenmeier displays should work again.
Description of developer facing changes:
ftdi2.pyhas been moved frommiscDepsintonvda, and significantly refactored.Description of development approach:
ftdi2.pyfrommiscdeps/pythontosource/ftdi2/__init__.pyftExceptionDecoratoras a ctypeserrcheckfunction_PY_*functions, look up the corresponding function in the D2XX Programmer’s Guide (revision 1.6) and implement the corresponding ctypes prototype inftd2xx.pyEnums, and move toftd2xx.pyftdi2.pywth the newftdi2package and document API differencesftdi2.pyfrom miscdeps (PR Remove ftdi2.py nvda-misc-deps#46)Testing strategy:
Asked affected users to test try builds.
Known issues with pull request:
None
Code Review Checklist: