Update commit refs#19294
Merged
Merged
Conversation
Member
|
any thoughts on removing these references altogether? the source of truth for these can be found in uv lock files and git commit history |
seanbudd
reviewed
Nov 28, 2025
seanbudd
reviewed
Nov 28, 2025
d14306c to
7a1e503
Compare
Member
Author
|
@seanbudd I'm fine removing the exact commits and such, but we should maybe consider doing so in a different commit. And I'd say the source of truth is |
seanbudd
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
follow-up #18480
follow-up #19105
Follow-up #19196
Summary of the issue:
Commit references in
projectDocs/dev/createDevEnvironment.mdwere out of date.There were also references to nvda_dmp and the old ftd2xx.py.
Description of user facing changes:
None
Description of developer facing changes:
Description of runtime submodules now more accurately reflects reality.
Description of development approach:
Updated commit references and removed outdated items.
Testing strategy:
N/A
Known issues with pull request:
None
Code Review Checklist: