Remove ftdi2.py#46
Merged
Merged
Conversation
15 tasks
michaelDCurran
approved these changes
Oct 29, 2025
SaschaCowley
added a commit
to nvaccess/nvda
that referenced
this pull request
Oct 31, 2025
Fixes #19028 ### Summary of the issue: Papenmeier braille displays don't work with 64-bit NVDA. ### Description of user facing changes: Papenmeier displays should work again. ### Description of developer facing changes: * `ftdi2.py` has been moved from `miscDeps` into `nvda`, and significantly refactored. ### Description of development approach: * [x] Copy `ftdi2.py` from `miscdeps/python` to `source/ftdi2/__init__.py` * [x] Reimplement `ftExceptionDecorator` as a ctypes `errcheck` function * [x] For each of the `_PY_*` functions, look up the corresponding function in the [D2XX Programmer’s Guide](https://ftdichip.com/document/programming-guides/) (revision 1.6) and implement the corresponding ctypes prototype in `ftd2xx.py` * [x] Convert enumerations to actual `Enum`s, and move to `ftd2xx.py` * [x] Verify struct definitions * [x] Rename the various pythonic functions and methods according to NV Access' house style * [x] Update the copyright headers and docstrings * [x] Compare the old `ftdi2.py` wth the new `ftdi2` package and document API differences * [x] Remove `ftdi2.py` from miscdeps (PR nvaccess/nvda-misc-deps#46) * [x] Update miscdeps ### Testing strategy: Asked affected users to test try builds. ### Known issues with pull request: None ### Code Review Checklist: - [x] Documentation: - Change log entry - User Documentation - Developer / Technical Documentation - Context sensitive help for GUI changes - [ ] Testing: - Unit tests - System (end to end) tests - Manual testing - [x] UX of all users considered: - Speech - Braille - Low Vision - Different web browsers - Localization in other languages / culture than English - [x] API is compatible with existing add-ons. - [x] Security precautions taken. --------- Co-authored-by: Michael Curran <mick@nvaccess.org>
Member
|
Can you please update the README as well to remove mention of this? |
Merged
seanbudd
pushed a commit
that referenced
this pull request
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ftdi2module has been rewritten for direct inclusion in NVDA in nvaccess/nvda#19105. This PR removes the module frommiscDeps, and is a prerequisite for that PR.