Skip to content

Remove ftdi2.py#46

Merged
SaschaCowley merged 1 commit into
masterfrom
removeFtdi2
Oct 29, 2025
Merged

Remove ftdi2.py#46
SaschaCowley merged 1 commit into
masterfrom
removeFtdi2

Conversation

@SaschaCowley

Copy link
Copy Markdown
Member

The ftdi2 module has been rewritten for direct inclusion in NVDA in nvaccess/nvda#19105. This PR removes the module from miscDeps, and is a prerequisite for that PR.

@SaschaCowley SaschaCowley merged commit e1fbeb0 into master Oct 29, 2025
SaschaCowley added a commit to nvaccess/nvda that referenced this pull request Oct 31, 2025
Fixes #19028

### Summary of the issue:

Papenmeier braille displays don't work with 64-bit NVDA.

### Description of user facing changes:

Papenmeier displays should work again.

### Description of developer facing changes:

* `ftdi2.py` has been moved from `miscDeps` into `nvda`, and
significantly refactored.

### Description of development approach:

* [x] Copy `ftdi2.py` from `miscdeps/python` to
`source/ftdi2/__init__.py`
* [x] Reimplement `ftExceptionDecorator` as a ctypes `errcheck` function
* [x] For each of the `_PY_*` functions, look up the corresponding
function in the [D2XX Programmer’s
Guide](https://ftdichip.com/document/programming-guides/) (revision 1.6)
and implement the corresponding ctypes prototype in `ftd2xx.py`
* [x] Convert enumerations to actual `Enum`s, and move to `ftd2xx.py`
* [x] Verify struct definitions
* [x] Rename the various pythonic functions and methods according to NV
Access' house style
* [x] Update the copyright headers and docstrings
* [x] Compare the old `ftdi2.py` wth the new `ftdi2` package and
document API differences
* [x] Remove `ftdi2.py` from miscdeps (PR nvaccess/nvda-misc-deps#46)
* [x] Update miscdeps

### Testing strategy:

Asked affected users to test try builds.

### Known issues with pull request:

None

### Code Review Checklist:

- [x] Documentation:
  - Change log entry
  - User Documentation
  - Developer / Technical Documentation
  - Context sensitive help for GUI changes
- [ ] Testing:
  - Unit tests
  - System (end to end) tests
  - Manual testing
- [x] UX of all users considered:
  - Speech
  - Braille
  - Low Vision
  - Different web browsers
  - Localization in other languages / culture than English
- [x] API is compatible with existing add-ons.
- [x] Security precautions taken.

---------

Co-authored-by: Michael Curran <mick@nvaccess.org>
@seanbudd

seanbudd commented Nov 3, 2025

Copy link
Copy Markdown
Member

Can you please update the README as well to remove mention of this?

@SaschaCowley SaschaCowley mentioned this pull request Nov 6, 2025
seanbudd pushed a commit that referenced this pull request Nov 6, 2025
Follow-up to #43, #44 and #46.

    Remove mention of dump_syms.exe from the readme, as it's now fetched as neededin CI.
    Remove mention of ftdi2.py from the readme, as it is now included in nvaccess/nvda.
    Update notes on lilli.dll and how to get updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants