Update to Python 3.11 by seanbudd · Pull Request #15544 · nvaccess/nvda

seanbudd · 2023-09-28T02:05:25Z

Link to issue number:

Closes #12064
Closes #12551
Closes #15577
Closes #15167

Summary of the issue:

Python needs to be updated to 3.11, as Python 3.7 is EOL.
Python pip dependencies need to be updated to match the python upgrade.
typing_extensions is no longer needed.

Description of user facing changes

Performance and security enhancements from dependency upgrades.

Description of development approach

Updates python in build scripts
Updates pip dependencies
Set Windows 8.1 (Blue) as minimum windows version
Update references to python and windows version in docs
nose is replaced by the unittest module with xmlrunner to generate XML test output
drop python optimization to level 0 from level 1. level 1 removes asserts.

Testing strategy:

Alpha testing required

Known issues with pull request:

BrlAPI / BrlTTY will be broken until Update tools nvda-misc-deps#27 is merged and updated in master
There is an intermittent issue copying text in Chrome Update to Python 3.11 #15544 (comment)
NVDA's garbageHandler is more sensitive Update to Python 3.11 #15544 (comment)

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

LeonarddeR

Really love to see this flying!
Before this is merged, I'd like to suggest changing the launcher nsis script so that it has Windows 8.1 as the minimum required version as well.

seanbudd · 2023-09-28T14:14:03Z

Hi all, this is still a draft PR

seanbudd · 2023-10-02T23:29:24Z

Before this is merged, I'd like to suggest changing the launcher nsis script so that it has Windows 8.1 as the minimum required version as well.

@LeonarddeR

As far as I am aware nvdaLauncher.nsi doesn't check Windows versions

LeonarddeR · 2023-10-10T05:13:00Z

@seanbudd Would it be possible to provide a signed try build?

@codeofdusk

Fix-up of #15513 #15514 . Description of how this pull request fixes the issue: Add @codeofdusk attributions for Python 3.11 upgrade

seanbudd · 2023-10-12T05:28:24Z

@LeonarddeR - try build for this PR, not including brlapi support: https://ci.appveyor.com/api/buildjobs/1kkvl7p3kpu38ijm/artifacts/output%2Fnvda_snapshot_try-p311-min-29598%2Cafa0d928.exe

LeonarddeR · 2023-10-12T06:36:50Z

Thanks for the try build @seanbudd
From my first observations, all seems to work smoothly. That said, it looks like the garbage handler kicks in more often with errors like this:

Log snipped

WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Garbage collector has found one or more unreachable objects. See further warnings for specific objects. Stack trace: File "nvda.pyw", line 399, in File "core.pyc", line 813, in main File "wx\core.pyc", line 2262, in MainLoop File "wx\core.pyc", line 3427, in File "core.pyc", line 746, in processRequest File "core.pyc", line 762, in Notify File "queueHandler.pyc", line 97, in pumpAll File "queueHandler.pyc", line 64, in flushQueue File "eventHandler.pyc", line 84, in _queueEventCallback File "eventHandler.pyc", line 322, in executeEvent File "eventHandler.pyc", line 355, in doPreGainFocus File "api.pyc", line 163, in setFocusObject File "treeInterceptorHandler.pyc", line 50, in update File "NVDAObjects\__init__.pyc", line 430, in _get_treeInterceptor File "treeInterceptorHandler.pyc", line 42, in getTreeInterceptor File "NVDAObjects\IAccessible\chromium.pyc", line 84, in __contains__ File "comtypes\_memberspec.pyc", line 482, in __call__ File "comtypes\client\__init__.pyc", line 47, in wrap_outparam File "comtypes\client\__init__.pyc", line 100, in GetBestInterface File "comtypes\client\dynamic.pyc", line 29, in Dispatch File "comtypes\automation.pyc", line 776, in GetTypeInfo File "monkeyPatches\comtypesMonkeyPatches.pyc", line 157, in newGetTypeInfo File "monkeyPatches\comtypesMonkeyPatches.pyc", line 31, in __call__ File "monkeyPatches\comtypesMonkeyPatches.pyc", line 128, in newCpbDel File "garbageHandler.pyc", line 67, in notifyObjectDeletion WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.115) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.116) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.117) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.118) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.118) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.118) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.118) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.118) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.118) - MainThread (17080): Deleting unreachable object WARNING - garbageHandler.notifyObjectDeletion (08:34:36.118) - MainThread (17080): Deleting unreachable object ERROR - garbageHandler._collectionCallback (08:34:36.119) - MainThread (17080): Found at least 40 unreachable objects in run

This was observed when arrowing through the list of chats in Teams 2.0.

I think we need to investigate what changes happend to garbage collection. It somehow looks like newer Python 3 is better in detecting abandoned objects itself.

seanbudd · 2023-10-12T23:05:01Z

@LeonarddeR @codeofdusk - these minor issues will have to be handled in a separate issue/PR, once this has been merged

michaelDCurran

In order to get maximum testing, I would recommend merging this sooner than later, acknowledging though that brlTTY support is currently not functional and a fix may still be some time away. We should not however branch for beta until a new brlAPI module compatible with Python 3.11 is available of course.

Update to Python 3.11

0b18089

seanbudd requested review from a team as code owners September 28, 2023 02:05

seanbudd requested review from Qchristensen and michaelDCurran September 28, 2023 02:05

update changes

d69c98f

seanbudd mentioned this pull request Sep 28, 2023

Python 3.11 upgrade cleanup #15546

Merged

5 tasks

This comment was marked as resolved.

Sign in to view

seanbudd marked this pull request as draft September 28, 2023 03:25

seanbudd commented Sep 28, 2023

View reviewed changes

Comment thread user_docs/en/changes.t2t Outdated

LeonarddeR reviewed Sep 28, 2023

View reviewed changes

Comment thread requirements.txt Outdated

Comment thread nvdaHelper/readme.md

fix py2exe

ce59979

This comment was marked as resolved.

Sign in to view

seanbudd added 2 commits September 28, 2023 17:40

fix compile

465ed71

update linker subsystem

5bd87a6

This comment was marked as resolved.

Sign in to view

lukaszgo1 reviewed Sep 28, 2023

View reviewed changes

Comment thread requirements.txt Outdated

Comment thread requirements.txt Outdated

Comment thread requirements.txt

Comment thread source/setup.py

Comment thread user_docs/en/userGuide.t2t Outdated

seanbudd added 2 commits October 3, 2023 10:36

fixup isSupportedOS

573a09f

drop nose as dependency

0acdbe9

seanbudd added the api-breaking-change label Oct 3, 2023

seanbudd added 4 commits October 3, 2023 11:56

fix server 2012 r2 ref

cf5f960

use xmlrunner for xml unit test output

c6fcafa

fix unit test report name

5e99bc6

fix abstract method unit test regex changes

6145669

This comment was marked as resolved.

Sign in to view

seanbudd added the blocked label Oct 12, 2023

seanbudd marked this pull request as draft October 12, 2023 02:26

Add @codeofdusk attributions for Python 3.11 upgrade (#15609)

afa0d92

Fix-up of #15513 #15514 . Description of how this pull request fixes the issue: Add @codeofdusk attributions for Python 3.11 upgrade

seanbudd mentioned this pull request Oct 12, 2023

Update tools nvaccess/nvda-misc-deps#27

Merged

seanbudd marked this pull request as ready for review October 15, 2023 22:44

michaelDCurran approved these changes Oct 16, 2023

View reviewed changes

Merge branch 'master' into py311-min

5cf56cd

seanbudd removed the blocked label Oct 16, 2023

seanbudd merged commit 01f3e1e into master Oct 16, 2023

seanbudd deleted the py311-min branch October 16, 2023 02:50

nvaccessAuto added this to the 2024.1 milestone Oct 16, 2023

LeonarddeR mentioned this pull request Oct 17, 2023

Remove remaining support for Windows 7 start after logon #15644

Merged

5 tasks

LeonarddeR mentioned this pull request Oct 20, 2023

Restore support for brltty #15658

Merged

5 tasks

seanbudd mentioned this pull request Jan 23, 2024

Bump Pillow version #16082

Merged

lukaszgo1 mentioned this pull request Feb 22, 2024

NVDA 24.1b7 not working with BAUM braille displays properly #16212

Open

seanbudd mentioned this pull request Feb 23, 2024

Only raise assertions for source code #16215

Merged

5 tasks

josephsl mentioned this pull request Aug 13, 2025

Enforce Windows 10 requirement for NVDA #18688

Merged

6 tasks

SaschaCowley mentioned this pull request May 4, 2026

Missing six module in Python environment in NVDA 2026.1 RC1 #20037

Closed

Uh oh!

Conversation

seanbudd commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

LeonarddeR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seanbudd commented Sep 28, 2023

Uh oh!

seanbudd commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

LeonarddeR commented Oct 10, 2023

Uh oh!

seanbudd commented Oct 12, 2023

Uh oh!

LeonarddeR commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanbudd commented Oct 12, 2023

Uh oh!

michaelDCurran left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

seanbudd commented Sep 28, 2023 •

edited

Loading

seanbudd commented Oct 2, 2023 •

edited

Loading

LeonarddeR commented Oct 12, 2023 •

edited

Loading