Support retrieving the status bar of Windows File Explorer (#6769) taken over after abandoned #12371#12845
Conversation
Re: nvaccess#12371 (comment) Co-authored-by: Michael Curran <michaelDCurran@users.noreply.github.com>
…d one for later versions of Windows. Provide different implementation for Win7
… in Windows 10's Quick access
|
@michaelDCurran Since you're already familiar with the code from #12371 would you be able to review this? I believe I've addressed all your concerns from the review on that PR. |
|
Tested on Windows 10 20H2 (64-bit) build 19042.1165. I hope to see it in NVDA 2021.3 for my own usage. This has also been requested many times in the French community. @michaelDCurran do you think this PR could be added in 2021.3 milestone? Thanks. |
|
@michaelDCurran Given there is clearly a community demand for this, and that you've explained on #12371 what needs to happen for this being approved and all of these are addressed may I ask what stops this from being looked at? |
|
Also CCing @feerrenrut to set a release milestone for this PR. |
|
There has been several request for this on the users list recently. |
…me (#13135) Fix-up of PR #12845 Summary of the issue: PR #12845 added additional type hints to methods on appModuleHandler.AppModule. Unfortunately presence of these annotations can cause a crash when uninstalling add-ons importing gui in their installTasks module. Description of how this pull request fixes the issue: This PR takes advantage of Postponed Evaluation of Annotations introduced in PEP 563 to avoid type hints in appModuleHandler being evaluated at import time.
First of all many thanks to @JulienCochuyt for most of this work.
Link to issue number:
Fixes #6769
Superseedes #12371
Summary of the issue:
Currently, the Window File Explorer cannot be retrieved using the
reportStatusLineglobal command.Description of how this pull request fixes the issue:
explorerapp module.api.getStatusBarTextexplorer.AppModule.getStatusBarTextas inspired by @ruifontes prototype in Nvda utters unavailable after copying files #6842 (comment) (hinted by @feerrenrut in Can't read status bar in File Explorer (Windows 10) #6769 (comment)) but in a slightly more complex way - trying to cover more unexpected cases.Testing strategy:
@JulienCochuyt 's testing:
Additionally I've tested under Windows 7, Server 2012, Windows 10 1511, 1809 and latest preview of Windows 11 - in all cases status bar has been retrieved successfully.
Known issues with pull request:
May possibly not work under some version of Windows not described in the testing above, but since this code works from Server 2012 up to Windows 11 without any changes I consider this pretty unlikely.
Change log entries:
Changes
NVDA+end(desktop) /NVDA+shift+end(laptop).For Developers
Code Review Checklist:
Changes from #12371 :
controlTypes