Support retrieving the status bar of Windows File Explorer (#6769)#12371
Support retrieving the status bar of Windows File Explorer (#6769)#12371JulienCochuyt wants to merge 3 commits into
Conversation
michaelDCurran
left a comment
There was a problem hiding this comment.
The UIA walker part looks fine to me.
The getStatusbarText code is a bit complex and I also have no idea how robust that would be on different Windows versions. Perhaps @josephsl has some idea?
If this can be tested on Win 7, Win 8.1 and Win 10, then I'm good with this.
Re: nvaccess#12371 (comment) Co-authored-by: Michael Curran <michaelDCurran@users.noreply.github.com>
|
I've tested code from this PR on Windows 7, Server 2012, Windows 10 1511, 1809 and 20H1 and aside from Windows 7 which requires a pretty different implementation it works pretty well. In the |
|
@JulienCochuyt Do you intent to continue this work? |
Re: nvaccess#12371 (comment) Co-authored-by: Michael Curran <michaelDCurran@users.noreply.github.com>
|
@JulienCochuyt Since this seemed more or less abandoned, and required changes to work on older Windows versions (which, as you've indicated in the PR description you're unable to test yourself) I've created #12845 which superseets this. I hope you do not mint. |
|
As per @lukaszgo1, I'm going to close this as abandoned and refer people to #12845 |
…ken over after abandoned #12371 (#12845) Fixes #6769 Superseedes #12371 Summary of the issue: Currently, the Window File Explorer cannot be retrieved using the reportStatusLine global command. Description of how this pull request fixes the issue: • Take advantage of Status bar handling: allow app modules to define their own routines to fetch status bar and use it in status bar command in global commands #4640 to implement custom status bar retrieval by the explorer app module. • Use a UIAWalker to retrieve it, as hinted by @josephsl in Can't read status bar in File Explorer (Windows 10) #6769 (comment) • Still, instead of overlaying the status bar of its children for concerns expressed in Can't read status bar in File Explorer (Windows 10) #6769 (comment), allow app modules to provide their custom implementation of api.getStatusBarText • Implement explorer.AppModule.getStatusBarText as inspired by @ruifontes prototype in Nvda utters unavailable after copying files #6842 (comment) (hinted by @feerrenrut in Can't read status bar in File Explorer (Windows 10) #6769 (comment)) but in a slightly more complex way - trying to cover more unexpected cases.
Link to issue number:
Fixes #6769
Summary of the issue:
Currently, the Window File Explorer cannot be retrieved using the
reportStatusLineglobal command.Description of how this pull request fixes the issue:
explorerapp module.api.getStatusBarTextexplorer.AppModule.getStatusBarTextas inspired by @ruifontes prototype in Nvda utters unavailable after copying files #6842 (comment) (hinted by @feerrenrut in Can't read status bar in File Explorer (Windows 10) #6769 (comment)) but in a slightly more complex way - trying to cover more unexpected cases.Testing strategy:
Known issues with pull request:
This is my first UIA work ever: Review with caution!
I've tried to set safeguards on expectations, but there might be huge differences between Windows versions and I'm not able to test all of them.
Change log entries:
New features
Changes
In Windows 10, the File Explorer status bar can now be retrieved using the standard gesture
NVDA+end(desktop) /NVDA+shift+end(laptop).For Developers
Code Review Checklist: