Fix-up of PR 12845: Work around a crash when uninstalling add-ons by taking advantage of lazy evaluation of type hints.#13135
Merged
Conversation
seanbudd
approved these changes
Dec 5, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of PR #12845
Summary of the issue:
PR #12845 added additional type hints to methods on
appModuleHandler.AppModule. Unfortunately presence of these annotations can cause a crash when uninstalling add-ons importingguiin theirinstallTasksmodule. Log from the crash is as follows:Description of how this pull request fixes the issue:
This PR takes advantage of Postponed Evaluation of Annotations introduced in PEP 563 to avoid type hints in
appModuleHandlerbeing evaluated at import time.Testing strategy:
guiininstallTasks(appModuleHandler.AppModule.getStatusBarTextby executingtyping.get_type_hints(appModuleHandler.AppModule.getStatusBarText)both before and after this change - made sure they has not changed.Known issues with pull request:
None known
Change log entries:
None needed - unreleased regression.
Code Review Checklist: