Windows 10 Settings: remove progress bar behavior from System/Sound/input and output volume meters#10412
Merged
michaelDCurran merged 1 commit intoOct 23, 2019
Conversation
…ut/output volume meter. Re nvaccess#10411. In Windows 10 Version 1803 (April 2018 Update, specifically withj build 17035) and later, Windows 10's Settings app added System/Sound page, moving Sound property sheet from Control Panel to Settings. However, this page includes an anoying progress bar which is really a volume meter, causing NVDA to announce progress bar information. Thus remove progress bar behavior so NVDA can remain silent.
Contributor
Author
|
Hi, Differences from #10410
Thanks. |
Collaborator
|
Note that another difference is that this doesn't add the Meter role. |
Contributor
Author
|
Hi, yep – I’m sure we will eventually add “volume meter” role if the need arises, but for now, removing the behavior is sufficient. Thanks.
From: Leonard de Ruijter <notifications@github.com>
Sent: Monday, October 21, 2019 11:04 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Windows 10 Settings: remove progress bar behavior from System/Sound/input and ouput volume meters (#10412)
Note that another difference is that this doesn't add the Meter role.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#10412?email_source=notifications&email_token=AB4AXEABMXEYR2H2J4DDSEDQP2JT7A5CNFSM4JDKY4VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4UCNQ#issuecomment-544817462> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEFBLGZOOZGURCUS2RLQP2JT7ANCNFSM4JDKY4VA> .
|
michaelDCurran
approved these changes
Oct 23, 2019
michaelDCurran
added a commit
that referenced
this pull request
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10411
Follow-up to #10410
Summary of the issue:
NVDA announces progress bar information in System/Sound in Windows 10 Settings app in Version 1803 and later.
Description of how this pull request fixes the issue:
In Windows 10 Version 1803 (April 2018 Update, specifically with build 17035) and later, Windows 10's Settings app added System/Sound page, moving Sound property sheet from Control Panel to Settings. However, this page includes an annoying progress bar which is really a volume meter, causing NVDA to announce progress bar information. Thus remove progress bar behavior so NVDA can remain silent.
Testing performed:
Tested via Windows 10 App Essentials add-on and on Version 1909 (build 18363) and other builds.
Known issues with pull request:
None
Change log entry:
Bug fixes:
In Settings app in Windows 10 April 2018 Update and later, NVDA will no longer announce progress bar information for volume meter found in System/Sound page. (#10284