Silence the volume meters in the Windows 10 System Settings app#10410
Closed
michaelDCurran wants to merge 2 commits into
Closed
Silence the volume meters in the Windows 10 System Settings app#10410michaelDCurran wants to merge 2 commits into
michaelDCurran wants to merge 2 commits into
Conversation
…ricing the role from progressBar to meter.
josephsl
suggested changes
Oct 22, 2019
josephsl
left a comment
Contributor
There was a problem hiding this comment.
Hi,
I'm afraid this one does not address the input volume - I also think there were changes between April 2018 Update and May 2019 Update.
Thanks.
Member
Author
|
Where is the input volume on that page? I couldn't find it.
I also don't hear it post 1903.
If you can give me its UIA automationId I can add it easily enough.
|
Contributor
|
Hi, Note that when I tested this in build 18363, progress bar sound was heard. Thanks. |
Contributor
|
Hi, it shows up if a microphone is connected, and in post-1903, the progress bar has no automation ID, thus in my add-on, I use sibling object lookup. Thanks.
From: Michael Curran <notifications@github.com>
Sent: Monday, October 21, 2019 6:31 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Review requested <review_requested@noreply.github.com>
Subject: Re: [nvaccess/nvda] Silence the volume meters in the Windows 10 System Settings app (#10410)
Where is the input volume on that page? I couldn't find it.
I also don't hear it post 1903.
If you can give me its UIA automationId I can add it easily enough.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#10410?email_source=notifications&email_token=AB4AXEBSM3IUEMVEOEZI3XTQPZJVPA5CNFSM4JDJE4W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4JJWI#issuecomment-544773337> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEFEY3AHSLWGSDQUSLDQPZJVPANCNFSM4JDJE4WQ> .
|
Member
Author
|
@josephsl oh... if you've already got this in your add-on, it would be great if you could put that into a pr and I'll close this one? |
Contributor
|
Hi, that I can do within the next hour – mine will deal with Version 1803 onwards as that was the one that introduced the new volume progress bar (speaking of my add-ons, feel free to let me know if there are things in there that Microsoft thinks are high priority for NVDA Core). Thanks.
From: Michael Curran <notifications@github.com>
Sent: Monday, October 21, 2019 10:08 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Silence the volume meters in the Windows 10 System Settings app (#10410)
@josephsl <https://github.com/josephsl> oh... if you've already got this in your add-on, it would be great if you could put that into a pr and I'll close this one?
We've had a query from Microsoft to fix this in NVDA core.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#10410?email_source=notifications&email_token=AB4AXECEHNB46JFDPASSMGDQP2DEZA5CNFSM4JDJE4W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4ROUY#issuecomment-544806739> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEC7XOL3HV227SKCDRTQP2DEZANCNFSM4JDJE4WQ> .
|
This was referenced Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
When on the Sound page of the Windows 10 System Settings app, NVDA constantly plays progress bar beeps due to the volume meter being treated as a progress bar.
Description of how this pull request fixes the issue:
This pr adds a new 'meter' role, and forces these volume meters to have the meter role, and not use the ProgressBar NVDAObject behavior.
Testing performed:
Opened the sound page in the Settings app. Ensured that NVDA no longer played progress bar beeps.
Known issues with pull request:
None.
Change log entry:
Bug fixes: