Fix example variables using - in their name#635
Merged
fdncred merged 2 commits intonushell:mainfrom Oct 13, 2022
holly-hacker:fix-invalid-variable-names
Merged
Fix example variables using - in their name#635fdncred merged 2 commits intonushell:mainfrom holly-hacker:fix-invalid-variable-names
- in their name#635fdncred merged 2 commits intonushell:mainfrom
holly-hacker:fix-invalid-variable-names
Conversation
fdncred
reviewed
Oct 13, 2022
Contributor
|
It all looks good except the one comment I made. If you remove that one, and perhaps fix it in the nushell code, we can land this PR. |
6 tasks
This will be fixed by nushell/nushell#6716
ayax79
pushed a commit
to ayax79/nushell.github.io
that referenced
this pull request
Jun 26, 2024
…#635) related to - nushell/nushell#10456 - nushell#1071 ## description after the changes on boolean switches from nushell/nushell#10456, we need to not annotate then with `: bool` when part of a public API. this PR is required for nushell#1071 to move forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes examples using the
-character in their name, which does not seem to be valid in nu 0.69.1.I found these occurences with the regexes
let \w+-and\$\w+-, so it's possible I missed something.