Fix invalid variable name in input command docs#6716
Merged
fdncred merged 1 commit intonushell:mainfrom Oct 13, 2022
holly-hacker:fix-invalid-variable-name-in-doc
Merged
Fix invalid variable name in input command docs#6716fdncred merged 1 commit intonushell:mainfrom holly-hacker:fix-invalid-variable-name-in-doc
input command docs#6716fdncred merged 1 commit intonushell:mainfrom
holly-hacker:fix-invalid-variable-name-in-doc
Conversation
fdncred
pushed a commit
to nushell/nushell.github.io
that referenced
this pull request
Oct 13, 2022
* Fix example variables using `-` in their name * Undo change to auto-generated documentation. This will be fixed by nushell/nushell#6716
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes invalid syntax in the example of the
inputcommand. Previously, it contained a variable nameuser-input, which is not valid in nu 0.69.1. Related to nushell/nushell.github.io#635.Tests
Make sure you've done the following:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspace --features=extrato check that all the tests passI didn't change any code but ran the test suite anyway and got the following test failure. Seems like this test is not locale aware? :)