Put heavy dataframe dependencies behind feature flag#9971
Merged
rgwood merged 1 commit intonushell:mainfrom Aug 10, 2023
Merged
Put heavy dataframe dependencies behind feature flag#9971rgwood merged 1 commit intonushell:mainfrom
rgwood merged 1 commit intonushell:mainfrom
Conversation
sholderbach
approved these changes
Aug 10, 2023
Member
sholderbach
left a comment
There was a problem hiding this comment.
This will make operations like cargo test -p nu-cmd-dataframe a bit surprising, but I think it is overall a good thing for the project.
Contributor
|
I'm having a hard time compiling with dataframes now. |
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Aug 10, 2023
Building broke silently. `nu` needs to enable the `dataframe` feature of `nu-cmd-dataframe` Still worth investigating if we can harden the CI against this.
fdncred
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Description Building broke silently. `nu` needs to enable the `dataframe` feature of `nu-cmd-dataframe` # User-Facing Changes Building with `cargo build --features dataframe` works again. # Tests + Formatting Still worth investigating if we can harden the CI against this.
Contributor
|
Stefan figured it out #9974 |
Contributor
Author
|
Oops, thanks Stefan! |
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Aug 31, 2023
Same logic as in nushell#9971 Prevents building the heavy polars and arrow dependencies when just running `cargo test --workspace` or `rust-analyzer`
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Aug 31, 2023
Same logic as in nushell#9971 Prevents building the heavy polars and arrow dependencies when just running `cargo test --workspace` or `rust-analyzer`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context from Discord: https://discord.com/channels/601130461678272522/615962413203718156/1138694933545504819
I was working on Nu for the first time in a while and I noticed that sometimes rust-analyzer takes a really long time to run
cargo checkon the entire workspace. I dug in and it was checking a bunch of dataframe-related dependencies even though thedataframefeature is not built by default.It looks like this is a regression of sorts, introduced by #9241. Thankfully the fix is pretty easy, we can make it so everything important in
nu-cmd-dataframeis only used when thedataframefeature is enabled.Impact on
cargo check --workspaceBefore this PR: 635 crates, 33.59s
After this PR: 498 crates, ~20s
(with the
moldlinker and acargo cleanbefore each run, the relative difference for incremental checks will likely be much larger)