Fixup dataframe build after #9971#9974
Merged
fdncred merged 1 commit intonushell:mainfrom Aug 10, 2023
Merged
Conversation
Building broke silently. `nu` needs to enable the `dataframe` feature of `nu-cmd-dataframe` Still worth investigating if we can harden the CI against this.
Member
|
@sholderbach |
Contributor
|
Thanks for figuring this out @sholderbach! |
Member
Author
I assume feature unification in conjunction with all the targets that need to be built for |
Member
Author
|
BTW |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building broke silently.
nuneeds to enable thedataframefeature ofnu-cmd-dataframeUser-Facing Changes
Building with
cargo build --features dataframeworks again.Tests + Formatting
Still worth investigating if we can harden the CI against this.