Skip to content

FIX: expand all the base_paths in std::test_dirs#8552

Merged
sholderbach merged 1 commit intonushell:mainfrom
amtoine:fix/stdlib/broken-dirs-on-macos
Mar 22, 2023
Merged

FIX: expand all the base_paths in std::test_dirs#8552
sholderbach merged 1 commit intonushell:mainfrom
amtoine:fix/stdlib/broken-dirs-on-macos

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Mar 21, 2023

Related to #8525.

Description

this should close #8528.

User-Facing Changes

$nothing

Tests + Formatting

$nothing

After Submitting

$nothing

@amtoine amtoine mentioned this pull request Mar 21, 2023
Closed
@fdncred fdncred added the A:std-library Defining and improving the standard library written in Nu label Mar 21, 2023
presidento
presidento reviewed Mar 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@presidento presidento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sholderbach
Copy link
Copy Markdown
Member

sholderbach commented Mar 22, 2023

Let's go!

@sholderbach sholderbach merged commit cb1eefd into nushell:main Mar 22, 2023
@amtoine amtoine deleted the fix/stdlib/broken-dirs-on-macos branch March 22, 2023 16:53
@amtoine amtoine mentioned this pull request Mar 29, 2023
Merged
fdncred pushed a commit that referenced this pull request Mar 29, 2023
@amtoine
REFACTOR: remove the redundant path expand from the tests of the st…
ed0fce9 
…andard library (#8666)

Related to #8653.

# Description
This PR removes the redundant `path expand`s introduced in #8552 and
#8576.

# User-Facing Changes
```
$nothing
```

# Tests + Formatting
the tests still pass on linux.

# After Submitting
```
$nothing
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@presidento presidento presidento left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A:std-library Defining and improving the standard library written in Nu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

std::tests::test_dirs::test_dirs_command fails on MacOS

4 participants

@amtoine @sholderbach @presidento @fdncred