Skip to content

REFACTOR: remove the redundant path expand from the tests of the standard library#8666

Merged
fdncred merged 1 commit intonushell:mainfrom
amtoine:refactor/stdlib/remove-redundant-path-expand
Mar 29, 2023
Merged

REFACTOR: remove the redundant path expand from the tests of the standard library#8666
fdncred merged 1 commit intonushell:mainfrom
amtoine:refactor/stdlib/remove-redundant-path-expand

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Mar 29, 2023

Related to #8653.

Description

This PR removes the redundant path expands introduced in #8552 and #8576.

User-Facing Changes

$nothing

Tests + Formatting

the tests still pass on linux.

After Submitting

$nothing

@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Mar 29, 2023

let's see if the CI passes on MacOs 🤞

@sholderbach sholderbach added A:std-library Defining and improving the standard library written in Nu tests issues to add tests or fix tests labels Mar 29, 2023
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Mar 29, 2023

I'd like to test this manually, even though the CI is green. Just to be sure. I'll try to do it in a little while.

@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Mar 29, 2023

I'd like to test this manually, even though the CI is green. Just to be sure. I'll try to do it in a little while.

yeah of course, good idea 👍

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Mar 29, 2023 •
edited
Loading

I don't really understand what's going on here. This should work 🤔

NU_LOG_LEVEL=DEBUG nu crates/nu-utils/standard_library/tests.nu
INF|2023-03-29T16:12:01.363|Running tests in test_asserts
DBG|2023-03-29T16:12:01.366|Running test test_assert
DBG|2023-03-29T16:12:01.383|Running test test_assert_equal
DBG|2023-03-29T16:12:01.400|Running test test_assert_error
DBG|2023-03-29T16:12:01.420|Running test test_assert_greater
DBG|2023-03-29T16:12:01.436|Running test test_assert_greater_or_equal
DBG|2023-03-29T16:12:01.452|Running test test_assert_length
DBG|2023-03-29T16:12:01.469|Running test test_assert_less
DBG|2023-03-29T16:12:01.485|Running test test_assert_less_or_equal
DBG|2023-03-29T16:12:01.502|Running test test_assert_not_equal
INF|2023-03-29T16:12:01.519|Running tests in test_dirs
DBG|2023-03-29T16:12:01.519|Running test test_dirs_command
Error:
  × list is just pwd after initialization

INF|2023-03-29T16:12:01.554|Running tests in test_logger
DBG|2023-03-29T16:12:01.554|Running test test_critical
DBG|2023-03-29T16:12:01.605|Running test test_debug
DBG|2023-03-29T16:12:01.654|Running test test_error
DBG|2023-03-29T16:12:01.702|Running test test_info
DBG|2023-03-29T16:12:01.753|Running test test_warning
INF|2023-03-29T16:12:01.802|Running tests in test_std
DBG|2023-03-29T16:12:01.802|Running test test_path_add
Error:
  × some tests did not pass (see complete errors above):
  │
  │       test_asserts test_assert
  │       test_asserts test_assert_equal
  │       test_asserts test_assert_error
  │       test_asserts test_assert_greater
  │       test_asserts test_assert_greater_or_equal
  │       test_asserts test_assert_length
  │       test_asserts test_assert_less
  │       test_asserts test_assert_less_or_equal
  │       test_asserts test_assert_not_equal
  │     ⨯ test_dirs test_dirs_command
  │       test_logger test_critical
  │       test_logger test_debug
  │       test_logger test_error
  │       test_logger test_info
  │       test_logger test_warning
  │       test_std test_path_add

Let me make sure I'm on the latest main and try again.

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Mar 29, 2023

Good, I didn't have my change it. It works on the latest main. Thanks!

@fdncred fdncred merged commit ed0fce9 into nushell:main Mar 29, 2023
@amtoine amtoine deleted the refactor/stdlib/remove-redundant-path-expand branch March 30, 2023 16:34
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Mar 30, 2023

cooool 👍
that's a lot cleaner now, gg with the "path expansion" fix ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A:std-library Defining and improving the standard library written in Nu tests issues to add tests or fix tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amtoine @fdncred @sholderbach