Rename column name from command to name for consistency#7007
Merged
sophiajt merged 1 commit intonushell:mainfrom Nov 4, 2022
Merged
Rename column name from command to name for consistency#7007sophiajt merged 1 commit intonushell:mainfrom
sophiajt merged 1 commit intonushell:mainfrom
Conversation
Contributor
|
Thanks for the fix! Since this is technically a breaking change, would you mind documenting it in the blog post for the upcoming release? nushell/nushell.github.io#647 |
Contributor
Author
|
Yes, I just did a PR against the |
Hofer-Julian
pushed a commit
to Hofer-Julian/nushell
that referenced
this pull request
Jan 27, 2023
* Release notes for nushell 0.71 Please add your important new features and breaking changes to the release notes by commiting to/opening a PR against the `release-notes-0.71` branch! Thanks for helping out! * add right prompt release notes (nushell#650) * add right prompt release notes * add a comparison image * docs: documents the changes from nushell#6904 (nushell#653) * docs: document changes from nushell#7007 (nushell#659) Co-authored-by: David Matos <david@track32.nl> * Update breaking changes * Breaking change in `format filesize` * Stubs for themes of the release Listed some important improvements that might be worth telling the user about. * mention Reilly's changes for this release * Update 2022-11-08-nushell-0.71.md (nushell#664) * finish up blog post Co-authored-by: nibon7 <nibon7@163.com> Co-authored-by: Mel Massadian <melmassadian@gmail.com> Co-authored-by: David Matos <dmatos2012@users.noreply.github.com> Co-authored-by: David Matos <david@track32.nl> Co-authored-by: Reilly Wood <26268125+rgwood@users.noreply.github.com> Co-authored-by: Jakub Žádník <kubouch@gmail.com> Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR should close issue #6922, which renames the column name of
$nu.scope.commandsfrom "commands" to "name".Now, both commands have the same column name which helps for consistency.
Tests + Formatting
to check standard code formatting (cargo fmt --allapplies these changes) -[X]cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code style -[X]cargo test --workspace --features=extra` to check that all tests passUser-Facing Changes
If you're making changes that will affect the user experience of Nushell (ex: adding/removing a command, changing an input/output type, adding a new flag):