Detach externals so they don't freeze while buffering#664
Merged
sophiajt merged 1 commit intonushell:masterfrom Sep 13, 2019
Merged
Detach externals so they don't freeze while buffering#664sophiajt merged 1 commit intonushell:masterfrom
sophiajt merged 1 commit intonushell:masterfrom
Conversation
elferherrera
pushed a commit
to elferherrera/nushell
that referenced
this pull request
Feb 7, 2022
* Move fetch to extra * Move byte stream code to a function instead of copying it twice * Fix formatting issues * Make fetch a default command * Fix formatting
kubouch
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Move fetch to extra * Move byte stream code to a function instead of copying it twice * Fix formatting issues * Make fetch a default command * Fix formatting
Hofer-Julian
pushed a commit
to Hofer-Julian/nushell
that referenced
this pull request
Jan 27, 2023
* Release notes for nushell 0.71 Please add your important new features and breaking changes to the release notes by commiting to/opening a PR against the `release-notes-0.71` branch! Thanks for helping out! * add right prompt release notes (nushell#650) * add right prompt release notes * add a comparison image * docs: documents the changes from nushell#6904 (nushell#653) * docs: document changes from nushell#7007 (nushell#659) Co-authored-by: David Matos <david@track32.nl> * Update breaking changes * Breaking change in `format filesize` * Stubs for themes of the release Listed some important improvements that might be worth telling the user about. * mention Reilly's changes for this release * Update 2022-11-08-nushell-0.71.md (nushell#664) * finish up blog post Co-authored-by: nibon7 <nibon7@163.com> Co-authored-by: Mel Massadian <melmassadian@gmail.com> Co-authored-by: David Matos <dmatos2012@users.noreply.github.com> Co-authored-by: David Matos <david@track32.nl> Co-authored-by: Reilly Wood <26268125+rgwood@users.noreply.github.com> Co-authored-by: Jakub Žádník <kubouch@gmail.com> Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #595, we're seeing issues where if an external gets to 64k it will freeze. This points to it filling its output buffer and not being able to continue. This in turn seemed to point to it not being running independently of the pipeline as it should. I've added detaches to external->external and external->internal so that they can run independently and the rest of the pipeline can pull as needed.