Fix quoting for command line args#5384
Merged
fdncred merged 3 commits intonushell:mainfrom Apr 30, 2022
Merged
Conversation
Contributor
|
seems a reasonable approach. let's see how it works. Thanks! |
uasi
commented
Apr 30, 2022
| "--commands" | "-c" => { | ||
| // FIXME: Use proper quoting. `escape_quote_string()` can't be used for now due to https://github.com/nushell/nushell/issues/5383. | ||
|
|
||
| args.next().map(|a| format!("`{}`", a)) |
Contributor
There was a problem hiding this comment.
Feel free to propose a 'proper quoting' fix too. :)
Contributor
|
I think this PR caused this issue
I used the next command |
Contributor
|
@elferherrera I just landed #5398. Can you see if it fixes your issue? |
Contributor
|
it seems that it didnt work |
Contributor
|
@elferherrera this should now be fixed in the latest main. Took a few tries, but I think I found it |
fennewald
pushed a commit
to fennewald/nushell
that referenced
this pull request
Jun 27, 2022
* Fix quoting for command line args * Replace custom quoting with escape_quote_string * Use raw string for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5370
Fixes #5371
Tests
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo build; cargo test --all --all-featuresto check that all the tests pass