Move uses of trim_quotes to unescape for filenames#5398
Merged
sophiajt merged 2 commits intonushell:mainfrom May 1, 2022
Merged
Move uses of trim_quotes to unescape for filenames#5398sophiajt merged 2 commits intonushell:mainfrom
sophiajt merged 2 commits intonushell:mainfrom
Conversation
3 tasks
fennewald
pushed a commit
to fennewald/nushell
that referenced
this pull request
Jun 27, 2022
* Move uses of trim_quotes to unescape for filenames * Fix Windows tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This tries to use unescaping wherever we're reading in a filename from the user. This should hopefully fix some of the jankiness around escaping we're seeing on Windows.
Tests
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo build; cargo test --all --all-featuresto check that all the tests pass