Partial workaround and deprecation warning for breaking change usage of #15654#15806
Merged
sholderbach merged 3 commits intonushell:mainfrom Jun 4, 2025
Merged
Conversation
Member
|
We still need this despite #15770, right? (or do you want to reimplement parts of this with the new logic? |
Member
Author
Yea we'll still need this, although it doesn't really integrate with #15770 since that only handles parse-time deprecation warnings (I would be interested in a follow-up that also had some mechanism for run-time deprecation warnings, but I'm not exactly sure what that would look like) |
45ed67c to
098e29f
Compare
Member
Author
|
I updated the wording of the error to try to be more clear (although it might be too wordy now..) and I also changed the
|
sholderbach
approved these changes
Jun 4, 2025
Member
sholderbach
left a comment
There was a problem hiding this comment.
Thanks, need to put a pin into that to properly remove your carapace hack :D
Comment on lines
+325
to
+327
| let carapace_suggestion = "re-run carapace init with version v1.3.3 or later\nor, change this to `{ $carapace_completer }`"; | ||
| let suggestion = match span_contents { | ||
| Cow::Borrowed("$carapace_completer") => carapace_suggestion.to_string(), |
kumarUjjawal
pushed a commit
to kumarUjjawal/nushell
that referenced
this pull request
Jun 5, 2025
nushell#15654 (nushell#15806) # Description Adds a temporary workaround to prevent nushell#15654 from being a breaking change when using a closure stored in a variable, and issues a warning. Also has a special case related to carapace-sh/carapace-bin#2796 which suggests re-running `carapace init`   # After Submitting Remove variable name detection after grace period
Merged
Bahex
pushed a commit
that referenced
this pull request
Jul 15, 2025
# Description Adds a proper `ShellWarning` enum which has the same functionality as `ParseWarning`. Also moves the deprecation from #15806 into `ShellWarning::Deprecated` with `ReportMode::FirstUse`, so that warning will only pop up once now. # User-Facing Changes Technically the change to the deprecation warning from #15806 is user facing but it's really not worth listing in the changelog
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Aug 25, 2025
# Description Adds a proper `ShellWarning` enum which has the same functionality as `ParseWarning`. Also moves the deprecation from nushell#15806 into `ShellWarning::Deprecated` with `ReportMode::FirstUse`, so that warning will only pop up once now. # User-Facing Changes Technically the change to the deprecation warning from nushell#15806 is user facing but it's really not worth listing in the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a temporary workaround to prevent #15654 from being a breaking change when using a closure stored in a variable, and issues a warning. Also has a special case related to carapace-sh/carapace-bin#2796 which suggests re-running
carapace initUser-Facing Changes
Tests + Formatting
After Submitting