Skip to content

Update Nushell init script for v0.105.0#2796

Merged
rsteube merged 1 commit intocarapace-sh:masterfrom
132ikl:default-change
Jun 4, 2025
Merged

Update Nushell init script for v0.105.0#2796
rsteube merged 1 commit intocarapace-sh:masterfrom
132ikl:default-change

Conversation

@132ikl
Copy link
Copy Markdown
Contributor

@132ikl 132ikl commented May 16, 2025

This is a preemptive PR to account for a breaking change which will be part of the next Nushell version, following the merge of nushell/nushell#15654. The change will be part of the v0.105.0 release, which will be on June 10th. This shouldn't be merged until then (or perhaps it could be merged early if carapace will have a release right before June 10th).

The default command now runs closures in order to support lazy evaluation, so to return a closure with default you must put the closure in the closure now. I've updated the Nushell init file to account for this.

sholderbach pushed a commit to nushell/nushell that referenced this pull request Jun 4, 2025
#15654 (#15806)

# Description
Adds a temporary workaround to prevent #15654 from being a breaking
change when using a closure stored in a variable, and issues a warning.
Also has a special case related to
carapace-sh/carapace-bin#2796 which suggests
re-running `carapace init`


![image](https://github.com/user-attachments/assets/783f3dbf-2a85-4aa5-ac66-efc584ac77fd)


![image](https://github.com/user-attachments/assets/c8fb5ae1-66a8-474c-8244-a22600f4da43)

# After Submitting
Remove variable name detection after grace period
@132ikl
Copy link
Copy Markdown
Contributor Author

132ikl commented Jun 4, 2025

@rsteube Our release will be on the 10th, so it's probably safe to merge this in soon. Thanks 😄

@132ikl 132ikl marked this pull request as ready for review June 4, 2025 15:57
@rsteube rsteube merged commit f4973f7 into carapace-sh:master Jun 4, 2025
3 checks passed
kumarUjjawal pushed a commit to kumarUjjawal/nushell that referenced this pull request Jun 5, 2025
nushell#15654 (nushell#15806)

# Description
Adds a temporary workaround to prevent nushell#15654 from being a breaking
change when using a closure stored in a variable, and issues a warning.
Also has a special case related to
carapace-sh/carapace-bin#2796 which suggests
re-running `carapace init`


![image](https://github.com/user-attachments/assets/783f3dbf-2a85-4aa5-ac66-efc584ac77fd)


![image](https://github.com/user-attachments/assets/c8fb5ae1-66a8-474c-8244-a22600f4da43)

# After Submitting
Remove variable name detection after grace period
@rsteube rsteube mentioned this pull request Jun 18, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants