Skip to content

fix force rm: should suppress error if directory is not found#11656

Merged
fdncred merged 2 commits intonushell:mainfrom
WindSoilder:force_rm
Jan 28, 2024
Merged

fix force rm: should suppress error if directory is not found#11656
fdncred merged 2 commits intonushell:mainfrom
WindSoilder:force_rm

Conversation

@WindSoilder
Copy link
Copy Markdown
Contributor

Description

Fix a breaking change which is introduced by #11621

rm -f /tmp/aaa shouldn't return error if /tmp/aaa/ doesn't exist.

User-Facing Changes

NaN

Tests + Formatting

Done

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Jan 28, 2024

Looks good to me. Thanks!

@fdncred fdncred merged commit 25b62c2 into nushell:main Jan 28, 2024
amtoine added a commit to nushell/nupm that referenced this pull request Jan 28, 2024
related to
- #62
- nushell/nushell#11656

## Description
this commit reverts #62 because it
was just a bug introduced recently and now fixed in
nushell/nushell#11656.
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Jan 29, 2024
related to
- #175
- nushell/nushell#11656

## Description
this commit reverts #175
because it was just a bug introduced recently and now fixed in
nushell/nushell#11656.
@hustcer hustcer added this to the v0.90.0 milestone Feb 3, 2024
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Feb 7, 2024
related to
- #175
- nushell/nushell#11656

## Description
this commit reverts #175
because it was just a bug introduced recently and now fixed in
nushell/nushell#11656.
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
…l#11656)

# Description
Fix a breaking change which is introduced by nushell#11621

`rm -f /tmp/aaa` shouldn't return error if `/tmp/aaa/` doesn't exist.

# User-Facing Changes
NaN

# Tests + Formatting
Done
@WindSoilder WindSoilder deleted the force_rm branch February 27, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants