remove the destination only if it exists#62
Merged
kubouch merged 2 commits intonushell:mainfrom Jan 28, 2024
Merged
Conversation
amtoine
added a commit
to amtoine/nu-git-manager
that referenced
this pull request
Jan 28, 2024
- should fix #172 - wait for nushell/nupm#62
amtoine
added a commit
to amtoine/nushell-nupm
that referenced
this pull request
Jan 28, 2024
This reverts commit 8fcec7a.
amtoine
added a commit
that referenced
this pull request
Jan 28, 2024
related to - #62 - nushell/nushell#11656 ## Description this commit reverts #62 because it was just a bug introduced recently and now fixed in nushell/nushell#11656.
amtoine
added a commit
to amtoine/nu-git-manager
that referenced
this pull request
Feb 7, 2024
- should fix #172 - wait for nushell/nupm#62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nupm install --forcetries to remove non-existing destinations #61Description
nupm install --forceshould not try tormthe content of$destinationif it does not exist.this PR adds a check for that and a test to the CI.