remove extern-wrapped and export extern-wrapped#11000
Merged
WindSoilder merged 2 commits intonushell:mainfrom Nov 16, 2023
Merged
remove extern-wrapped and export extern-wrapped#11000WindSoilder merged 2 commits intonushell:mainfrom
extern-wrapped and export extern-wrapped#11000WindSoilder merged 2 commits intonushell:mainfrom
Conversation
- remove the files with
```nushell
ls **/*.rs | find --regex extern_wrapped | each { rm --verbose $in.name }`
```
- run `:g/ExternWrapped/d` in `crates/nu-cmd-lang/src/default_context.rs`
- run `:g/extern_wrapped/d` in `crates/nu-cmd-lang/src/core_commands/mod.rs`
12 tasks
WindSoilder
approved these changes
Nov 16, 2023
Contributor
WindSoilder
left a comment
There was a problem hiding this comment.
Thanks! LGTM, I've searched around extern_wrapped and can't find anymore
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
follow-up to - nushell#10716 > **Important** > wait for between 0.87 and 0.88 to land this # Description it's time for removal again 😋 this PR removes `extern-wrapped` and `export extern-wrapped` in favor of `def --wrapped` # User-Facing Changes `extern-wrapped` and `export extern-wrapped` will not be found anymore. # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow-up to - nushell#10716 > **Important** > wait for between 0.87 and 0.88 to land this # Description it's time for removal again 😋 this PR removes `extern-wrapped` and `export extern-wrapped` in favor of `def --wrapped` # User-Facing Changes `extern-wrapped` and `export extern-wrapped` will not be found anymore. # Tests + Formatting # After Submitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to
extern-wrappedandexport extern-wrapped#10716Description
it's time for removal again 😋
this PR removes
extern-wrappedandexport extern-wrappedin favor ofdef --envUser-Facing Changes
extern-wrappedandexport extern-wrappedwill not be found anymore.Tests + Formatting
After Submitting