deprecate extern-wrapped and export extern-wrapped#10716
Merged
WindSoilder merged 2 commits intonushell:mainfrom Oct 19, 2023
Merged
deprecate extern-wrapped and export extern-wrapped#10716WindSoilder merged 2 commits intonushell:mainfrom
extern-wrapped and export extern-wrapped#10716WindSoilder merged 2 commits intonushell:mainfrom
Conversation
Member
Author
📯 the removal is ready in the
|
12 tasks
gaetschwartz
pushed a commit
to gaetschwartz/nushell
that referenced
this pull request
Oct 20, 2023
follow-up to - nushell#10566 # Description this PR deprecates the use of `extern-wrapped` and `export extern-wrapped` these two core commands will be removed in 0.88 # User-Facing Changes using `extern-wrapped` will give a warning ```nushell > extern-wrapped foo [...args] { print "foo" }; foo Error: × Deprecated command ╭─[entry nushell#2:1:1] 1 │ extern-wrapped foo [...args] { print "foo" }; foo · ───────┬────── · ╰── `extern-wrapped` is deprecated and will be removed in 0.88. ╰──── help: Use `def --wrapped` instead foo ``` # Tests + Formatting # After Submitting
amtoine
added a commit
to amtoine/scripts
that referenced
this pull request
Oct 25, 2023
WindSoilder
pushed a commit
that referenced
this pull request
Nov 16, 2023
follow-up to - #10716 > **Important** > wait for between 0.87 and 0.88 to land this # Description it's time for removal again 😋 this PR removes `extern-wrapped` and `export extern-wrapped` in favor of `def --wrapped` # User-Facing Changes `extern-wrapped` and `export extern-wrapped` will not be found anymore. # Tests + Formatting # After Submitting
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
follow-up to - nushell#10566 # Description this PR deprecates the use of `extern-wrapped` and `export extern-wrapped` these two core commands will be removed in 0.88 # User-Facing Changes using `extern-wrapped` will give a warning ```nushell > extern-wrapped foo [...args] { print "foo" }; foo Error: × Deprecated command ╭─[entry nushell#2:1:1] 1 │ extern-wrapped foo [...args] { print "foo" }; foo · ───────┬────── · ╰── `extern-wrapped` is deprecated and will be removed in 0.88. ╰──── help: Use `def --wrapped` instead foo ``` # Tests + Formatting # After Submitting
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
follow-up to - nushell#10716 > **Important** > wait for between 0.87 and 0.88 to land this # Description it's time for removal again 😋 this PR removes `extern-wrapped` and `export extern-wrapped` in favor of `def --wrapped` # User-Facing Changes `extern-wrapped` and `export extern-wrapped` will not be found anymore. # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow-up to - nushell#10716 > **Important** > wait for between 0.87 and 0.88 to land this # Description it's time for removal again 😋 this PR removes `extern-wrapped` and `export extern-wrapped` in favor of `def --wrapped` # User-Facing Changes `extern-wrapped` and `export extern-wrapped` will not be found anymore. # Tests + Formatting # After Submitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to
Description
this PR deprecates the use of
extern-wrappedandexport extern-wrappedthese two core commands will be removed in 0.88
User-Facing Changes
using
extern-wrappedwill give a warningTests + Formatting
After Submitting