Update winget submission workflow include only default msi files#10487
Merged
fdncred merged 2 commits intonushell:mainfrom Sep 24, 2023
Merged
Update winget submission workflow include only default msi files#10487fdncred merged 2 commits intonushell:mainfrom
fdncred merged 2 commits intonushell:mainfrom
Conversation
Contributor
|
ugh, i hate winget but we probably need to do this. thanks for your offer to stand-by. |
Contributor
|
Winget failed. No clue why. microsoft/winget-pkgs#122956 |
Contributor
|
This is the entry from the failed installer log. Not sure what it means exactly although ReplacePathsInWindowsTerminalProfile is in our wix file. |
Contributor
Author
|
Sorry that it fails again, I have no idea why it fails currently, as my change works as expected. So weird |
Contributor
|
I think the reason it's failing is because of trying to update the nu.json windows terminal fragment. |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
…hell#10487) ### Update winget submission workflow include only default msi files: --- The new release workflow after nushell#10457 will add full featured packages like: `nu-*-x86_64-windows-msvc-full.msi` and `nu-*-aarch64-windows-msvc-full.msi` (A release preview could be found here: https://github.com/nushell/nightly/releases/tag/nightly-6a2fd91 ) and this change will make sure only the default packages will be included just the same as before to make sure that nothing will be broken. BTW: Due to lots of changes made recently about the release workflow, I will stand-by for the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update winget submission workflow include only default msi files:
The new release workflow after #10457 will add full featured packages like:
nu-*-x86_64-windows-msvc-full.msiandnu-*-aarch64-windows-msvc-full.msi(A release preview could be found here: https://github.com/nushell/nightly/releases/tag/nightly-6a2fd91 ) and this change will make sure only the default packages will be included just the same as before to make sure that nothing will be broken.BTW: Due to lots of changes made recently about the release workflow, I will stand-by for the next release.