Skip to content

New version: Nushell.Nushell version 0.86.0#122956

Merged
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:masterfrom
fdncred:Nushell.Nushell-0.86.0-82A1BF82A832B4F6A905318D062FD88375FCAF3F
Oct 18, 2023
Merged

New version: Nushell.Nushell version 0.86.0#122956
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:masterfrom
fdncred:Nushell.Nushell-0.86.0-82A1BF82A832B4F6A905318D062FD88375FCAF3F

Conversation

@fdncred
Copy link
Copy Markdown
Contributor

@fdncred fdncred commented Oct 17, 2023

Pull request has been created with WinGet Releaser v2 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Oct 17, 2023
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@fdncred
Copy link
Copy Markdown
Contributor Author

fdncred commented Oct 17, 2023

trying to close and re-open because the only thing that has change between this and our last release is the guids.

@fdncred
Copy link
Copy Markdown
Contributor Author

fdncred commented Oct 17, 2023

Whether this issue is the problem create by the nushell maintainers or not, I'm honestly sick of the user experience of this repo. Not trying to disparage the maintainers and people here that support this and work so hard. It's just my viewpoint as a user. I have to essentially duplicate parts of this ci just to see what the error message is and it's a horrible experience watching it fail release after release after release with very little discernible error messages.

I run our msi on my desktop and it works fine. I run our msi in a Windows 11 sandbox and it fails with 1603. I then have to do something like msiexec /i "C:\Users\WDAGUtilityAccount\Desktop\Downloads\nu-0.86.0-x86_64-pc-windows-msvc.msi" /l*v c:\temp\insta.log just to get a log to see what's happening. Then it takes a msi-rocket scientist to figure out what all that gibberish means.

I really wish there was a better way to get releases into winget for our users. I'm sorry for being spicy about all this.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 17, 2023
@hustcer
Copy link
Copy Markdown
Contributor

hustcer commented Oct 17, 2023

I have an idea, but it still needs to be verified: Would it be less error prone if we chose exe files instead of the MSI files? Because MSI requires an installation process

@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-10-17 12:07:08.236 [CLI ] ShellExecute installer failed: 1603
CAQuietExec: Error 0xc0000135: Command line returned an error.
CAQuietExec: Error 0xc0000135:
QuietExec Failed
CAQuietExec: Error 0xc0000135: Failed in ExecCommon method CustomAction ReplacePathsInWindowsTerminalProfile returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox) Property(S): ErrorDialog = ErrorDlg
MSI (s) (10:D4) [12:07:07:950]: Product: nu -- Installation failed.
MSI (s) (10:D4) [12:07:07:950]: Windows Installer installed the product. Product Name: nu. Product Version: 0.86.0. Product Language: 1033. Manufacturer: The Nushell Project Developers. Installation success or error status: 1603.

  • 1603 often indicates a missing dependency.

@stephengillie
Copy link
Copy Markdown
Collaborator

Manual Validation ended with:
image

@stephengillie
Copy link
Copy Markdown
Collaborator

Hi @fdncred,

Do you know of a new dependency or other condition to install this version?

@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 18, 2023
@stephengillie
Copy link
Copy Markdown
Collaborator

I have an idea, but it still needs to be verified: Would it be less error prone if we chose exe files instead of the MSI files? Because MSI requires an installation process

Hi @hustcer,

This is an interesting theory, but unfortunately I don't have the time to gather the data. It might be possible to pull this from historical PRs, or it might be preferrable to collect new data by measuring equal packages in fresh VMs. If you decide to pursue this, please feel free to keep us informed.

@fdncred
Copy link
Copy Markdown
Contributor Author

fdncred commented Oct 18, 2023

Hi @fdncred,

Do you know of a new dependency or other condition to install this version?

I worked on it for 2 hours today and recreated the same log that you mentioned.

The wix file that generates the msi hasn't changed in four months. Our ci changes pretty frequently. No idea if that's causing a problem.

I'm just guessing, but it may have something to do with writing to c:\programdata. Although the last release had no problems with that.

This winget ci has always been super brittle for nushell.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 18, 2023
@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Shell-Execute labels Oct 18, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Oct 18, 2023
@fdncred
Copy link
Copy Markdown
Contributor Author

fdncred commented Oct 18, 2023

@stephengillie Thanks for your help and support.

We had to make the CI look like this

    - name: Setup Rust toolchain and cache
      uses: actions-rust-lang/setup-rust-toolchain@v1.5.0
      # WARN: Keep the rustflags to prevent from the winget submission error: `CAQuietExec:  Error 0xc0000135`
      with:
        rustflags: ''

instead of this

    - name: Setup Rust toolchain and cache
      uses: actions-rust-lang/setup-rust-toolchain@v1.5.0

That's it. I have no idea what rust flags are there by default nor what the rust flags are what stops our msi from installing.

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 2b3167f into microsoft:master Oct 18, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 18, 2023
@stephengillie
Copy link
Copy Markdown
Collaborator

@fdncred, you're quite welcome. That's a very interesting change to your CI - I have no idea that Rust was involved under the hood. Seems like it's everywhere these days. Happy hacking!

@fdncred fdncred deleted the Nushell.Nushell-0.86.0-82A1BF82A832B4F6A905318D062FD88375FCAF3F branch October 18, 2023 21:40
@wingetbot
Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants