REV: Loosen lookfor's import try/except again#22356
Merged
rossbar merged 1 commit intonumpy:mainfrom Oct 1, 2022
Merged
Conversation
Some BaseExceptions (at least the Skipped that pytest uses) need to be caught as well. It seems easiest to be practical and keep ignoring almost all exception in this particular code path. Effectively reverts parts of numpygh-19393 Closes numpygh-22345
lookfor's import try/except againlookfor's import try/except again
rossbar
approved these changes
Oct 1, 2022
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Oct 5, 2022
Some BaseExceptions (at least the Skipped that pytest uses) need to be caught as well. It seems easiest to be practical and keep ignoring almost all exception in this particular code path. Effectively reverts parts of numpygh-19393 Closes numpygh-22345 Co-authored-by: Sebastian Berg <sebastianb@nvidia.com>
lookfor's import try/except againlookfor's import try/except again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some BaseExceptions (at least the Skipped that pytest uses) need to be caught as well. It seems easiest to be practical and keep ignoring almost all exception in this particular code path.
Effectively reverts parts of gh-19393
Closes gh-22345
Doesn't seem worth sweating over the details here. I might consider deprecating the whole function...