MAINT: fix overly broad exception handling listed in LGTM#19393
Merged
mattip merged 3 commits intonumpy:mainfrom Jul 5, 2021
Merged
MAINT: fix overly broad exception handling listed in LGTM#19393mattip merged 3 commits intonumpy:mainfrom
mattip merged 3 commits intonumpy:mainfrom
Conversation
Relates to ticket numpy#19077
mattip
reviewed
Jul 2, 2021
BvB93
reviewed
Jul 2, 2021
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
BvB93
approved these changes
Jul 5, 2021
Member
BvB93
left a comment
There was a problem hiding this comment.
LGTM, the test failure seems to be unrelated.
Member
|
Thanks @wandrewjam and welcome. |
Contributor
Author
seberg
added a commit
to seberg/numpy
that referenced
this pull request
Sep 30, 2022
Some BaseExceptions (at least the Skipped that pytest uses) need to be caught as well. It seems easiest to be practical and keep ignoring almost all exception in this particular code path. Effectively reverts parts of numpygh-19393 Closes numpygh-22345
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Oct 5, 2022
Some BaseExceptions (at least the Skipped that pytest uses) need to be caught as well. It seems easiest to be practical and keep ignoring almost all exception in this particular code path. Effectively reverts parts of numpygh-19393 Closes numpygh-22345 Co-authored-by: Sebastian Berg <sebastianb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified instances of
except BaseException:andexcept:to catch narrower exception classes as suggested by LGTM.Relates to ticket #19077