BUG: floor_divide silently drops imaginary part of complex numbers.#13245
Closed
kaivu1999 wants to merge 1 commit intonumpy:masterfrom
kaivu1999:master
Closed
BUG: floor_divide silently drops imaginary part of complex numbers.#13245kaivu1999 wants to merge 1 commit intonumpy:masterfrom kaivu1999:master
floor_divide silently drops imaginary part of complex numbers.#13245kaivu1999 wants to merge 1 commit intonumpy:masterfrom
kaivu1999:master
Conversation
floor_divide silently drops imaginary part of complex numbers.
floor_divide silently drops imaginary part of complex numbers.floor_divide silently drops imaginary part of complex numbers.
Member
|
Failing tests, you should now be checking to see if |
Member
|
I think this should be discussed on the mailing list, perhaps we should issue a warning instead. |
Member
|
Going to close/reopen to test #13253. |
Member
|
Needs to fix failing tests and needs a release note. |
Member
|
@kaivu1999 Looks like you are not working on this PR anymore, I will close this PR, Feel free to reopen. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed floor_divide for complex numbers.
Deleted the function from
numpy/core/src/umath/loops.c.srcAnd removed complex type for floor_divide in
numpy/core/code_generators/generate_umath.pyCloses #13236.