TST: fail Azure CI if test failures#13253
Merged
charris merged 1 commit intonumpy:masterfrom Apr 2, 2019
Merged
Conversation
* fail Azure CI after test publication when there are test failures
Member
|
Let's see what this one does :) Thanks Tyler. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For comment / note here from Chuck: #13245 (comment)
Note that a nice summary of the failed tests is showing up in that PR now, but the problem is that Azure shows green instead of red as final result.
We need to set
failTaskOnFailedTeststotruefor Azure CI Publish stage to fail when one or more unit tests fail, so we get both the nice summary of failed tests, and a red "x" if there is a failure detected after publishing.I didn't actually change that setting in #13217, it was already the default, but because we no longer hard fail CI when the tests fail, we do need to hard fail after publishing if a failure is detected.
If a reviewer wants to be thorough they can intentionally introduce / remove a failure here for behavioural assessment on Azure.