TST: always publish Azure tests#13217
Merged
charris merged 1 commit intonumpy:masterfrom Mar 30, 2019
Merged
Conversation
* add Azure configuration directives to ensure that CI test results are always published, even in the case where there are test failures
Member
|
Unfortunately, there is no error that allows seeing the result :) Let's give it a shot and see what happens. Thanks Tyler. |
Member
|
This seems to result in Azure not reporting failure when a test fails. |
Contributor
Author
|
Could maybe switch |
Contributor
Author
|
That looks right based on their doc examples I think; that was always the default, it was the other flag that no longer hard fails on test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13210
See associated docs for Publish Test Results and task control options.
The key is likely setting
continueOnError: true, as docs suggest it should default to false--preventing the upload if tests fail.failTaskOnFailedTests: falseshould be the default, but let's be explicit on that too.