Skip to content

Windows Screengrab DPI fix improvements#2

Merged
nulano merged 2 commits intonulano:dpi_fixfrom
radarhere:dpi_fix
Aug 3, 2019
Merged

Windows Screengrab DPI fix improvements#2
nulano merged 2 commits intonulano:dpi_fixfrom
radarhere:dpi_fix

Conversation

@radarhere
Copy link
Copy Markdown

Two suggestions here.

  • Do not load the User32.dll at the start of the function, since it might not be used if PyArg_ParseTuple fails
  • Do not set dpiAwareness on the second SetThreadDpiAwarenessContext_function, since it is not used.

@nulano nulano changed the title DPI fix Windows Screengrab DPI fix improvements Aug 3, 2019
@nulano nulano merged commit f364b26 into nulano:dpi_fix Aug 3, 2019
@nulano
Copy link
Copy Markdown
Owner

nulano commented Aug 3, 2019

Thank you.

@radarhere radarhere deleted the dpi_fix branch August 3, 2019 11:52
radarhere added a commit that referenced this pull request Aug 12, 2019
* Load User32 after possible return

* Removed unused setting of variable
nulano pushed a commit that referenced this pull request Jun 23, 2020
Updated _open check to match _accept
radarhere pushed a commit that referenced this pull request Feb 22, 2021
Moved case transformation before initialization check
radarhere pushed a commit that referenced this pull request Feb 22, 2021
nulano pushed a commit that referenced this pull request Mar 30, 2021
nulano pushed a commit that referenced this pull request Apr 12, 2021
nulano pushed a commit that referenced this pull request May 24, 2022
Only install NumPy through pip on 64-bit.

Thanks for catching that, I'd forgotten the NumPy 1.21 problems were only on 64-bit.
nulano pushed a commit that referenced this pull request May 24, 2022
nulano pushed a commit that referenced this pull request May 24, 2022
Once comment is loaded, keep it for subsequent frames
radarhere pushed a commit that referenced this pull request Jun 30, 2022
nulano pushed a commit that referenced this pull request Aug 2, 2022
Check that orientation is still absent after reloading Exif
radarhere pushed a commit that referenced this pull request Oct 11, 2022
nulano pushed a commit that referenced this pull request Dec 31, 2022
Use jpeg_write_marker to write comment
nulano pushed a commit that referenced this pull request Jun 24, 2023
nulano pushed a commit that referenced this pull request Oct 9, 2023
Move osx_image into the individual jobs
radarhere pushed a commit that referenced this pull request Feb 15, 2024
nulano pushed a commit that referenced this pull request Mar 28, 2024
nulano pushed a commit that referenced this pull request Sep 22, 2024
Sort extensions alphabetically in error message
radarhere pushed a commit that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants