Fixed bug with rounding pixels to palette colors#6377
Merged
hugovk merged 5 commits intopython-pillow:mainfrom Jun 22, 2022
Merged
Fixed bug with rounding pixels to palette colors#6377hugovk merged 5 commits intopython-pillow:mainfrom
hugovk merged 5 commits intopython-pillow:mainfrom
Conversation
This fixes a bug with rounding pixels to the nearest palette color. Specifically, there is a typo with computing the minimum distance from a palette color to a given cache box. This is causing palette colors to be incorrectly excluded from consideration.
This was referenced Jun 19, 2022
Merged
Removed python-pillow#6377 from release notes
radarhere
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug with rounding pixels to the nearest palette color. Specifically, there is a typo with computing the minimum distance from a palette color to a given cache box. This is causing palette colors to be incorrectly excluded from consideration.
The bug can be observed in the following example:
Before the change, this prints
[0, 0, 0, 0, 0, 0, 0, 0, 32]. After the change, it prints[0, 0, 0, 0, 0, 32, 32, 32, 32].Changes proposed in this pull request: