[BlueOyster] Single-domain learning#2231
Merged
cygnusv merged 12 commits intonucypher:blue-oyster-mushroomsfrom Sep 16, 2020
Merged
[BlueOyster] Single-domain learning#2231cygnusv merged 12 commits intonucypher:blue-oyster-mushroomsfrom
cygnusv merged 12 commits intonucypher:blue-oyster-mushroomsfrom
Conversation
e8338e9 to
21179e3
Compare
21179e3 to
7f39e90
Compare
616ad8d to
16241cd
Compare
derekpierre
reviewed
Sep 14, 2020
| """ | ||
|
|
||
| VERSION = 1 # bump when static payload scheme changes | ||
| VERSION = 2 # bump when static payload scheme changes |
KPrasch
reviewed
Sep 14, 2020
|
|
||
| ALICE = Alice(network_middleware=RestMiddleware(), | ||
| domains={TEMPORARY_DOMAIN}, | ||
| domain=TEMPORARY_DOMAIN, |
KPrasch
reviewed
Sep 14, 2020
| self.registry = registry | ||
| if domains: # StakeHolder config inherits from character config, which has 'domains' - #1580 | ||
| self.network = list(domains)[0] | ||
| if domain: # StakeHolder config inherits from character config, which has 'domains' - See #1580 |
Member
There was a problem hiding this comment.
Just curious - why is domain optional here?
KPrasch
reviewed
Sep 14, 2020
| @@ -1209,7 +1210,7 @@ def run(self, | |||
| # if learning: # TODO: Include learning startup here with the rest of the services? | |||
KPrasch
approved these changes
Sep 15, 2020
Member
KPrasch
left a comment
There was a problem hiding this comment.
A comment and a question but no RFCs from me. Looks good!
jMyles
reviewed
Sep 15, 2020
| self.timestamp_bytes(), | ||
| bytes(self._interface_signature), | ||
| bytes(decentralized_identity_evidence), | ||
| bytes(VariableLengthBytestring(self.decentralized_identity_evidence)), # FIXME: Fixed length doesn't work with federated |
Contributor
There was a problem hiding this comment.
...why? This isn't fixed length?
Member
Author
There was a problem hiding this comment.
It is but not for federated, where it's a constant sorrow constant.
…hing outside it's either from the future or the past
7f39e90 to
52ac29e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed, for the moment we're done with multiple domains. This PR makes the necessary changes to use a single domain everywhere.
Closes:
tests/integration/learning/test_learning_versions.py.nucypher.datastore.keypairs.pytonucypher.crypto#2236: Relocatekeypairs.pyfromdatastoretocrypto.