Conversation
KPrasch
reviewed
Apr 15, 2020
| def __init__(self, node_metadata): | ||
| super().__init__(node_metadata) | ||
| self.checksum_address = to_checksum_address(node_metadata['public_address'][0]) | ||
| self.checksum_address = to_checksum_address(self.public_address) |
Contributor
Author
There was a problem hiding this comment.
...and much more optimal. Saves a keccak and other smaller cpu-bound operations compared to the previous method.
Contributor
There was a problem hiding this comment.
With other changes too, readability is certainly improved!
KPrasch
approved these changes
Apr 15, 2020
Relock dependencies
…atically when necessary.
…hat the (teacher) node is invalid, because we've been lazy until now.
…a bit of compatibility logic in the tests here.
tuxxy
reviewed
Apr 16, 2020
Comment on lines
+462
to
+471
| if eager: | ||
| node.mature() | ||
| stranger_certificate = node.certificate | ||
| except AttributeError: | ||
| # Probably a sprout. | ||
| try: | ||
| if grow_node_sprout_into_node: | ||
| node.mature() | ||
| stranger_certificate = node.certificate | ||
| else: | ||
| # TODO: Well, why? What about eagerness, popping listeners, etc? We not doing that stuff? NRN | ||
| return node | ||
| except Exception as e: | ||
| # Whoops, we got an Alice, Bob, or something totally wrong... | ||
| raise self.NotATeacher(f"{node.__class__.__name__} does not have a certificate and cannot be remembered.") | ||
|
|
||
| # Store node's certificate - It has been seen. | ||
| certificate_filepath = self.node_storage.store_node_certificate(certificate=stranger_certificate) | ||
| # Store node's certificate - It has been seen. | ||
| certificate_filepath = self.node_storage.store_node_certificate(certificate=stranger_certificate) | ||
|
|
||
| # In some cases (seed nodes or other temp stored certs), | ||
| # this will update the filepath from the temp location to this one. | ||
| node.certificate_filepath = certificate_filepath | ||
| # In some cases (seed nodes or other temp stored certs), | ||
| # this will update the filepath from the temp location to this one. | ||
| node.certificate_filepath = certificate_filepath |
Contributor
There was a problem hiding this comment.
This whole thing is looking really nice now.
tuxxy
reviewed
Apr 16, 2020
| verifying_keys_match = sprout.verifying_key == self.public_keys(SigningPower) | ||
| encrypting_keys_match = sprout.encrypting_key == self.public_keys(DecryptingPower) | ||
| addresses_match = sprout.public_address == self.canonical_public_address | ||
| evidence_matches = sprout.decentralized_identity_evidence == self.__decentralized_identity_evidence |
tuxxy
reviewed
Apr 16, 2020
Contributor
tuxxy
left a comment
There was a problem hiding this comment.
Really liking these changes.
tuxxy
approved these changes
Apr 16, 2020
michwill
reviewed
Apr 19, 2020
| assert len(all_known_nodes) == len(all_stored_nodes) | ||
| assert all_stored_nodes == all_known_nodes | ||
|
|
||
| known_checksums = sorted([n.checksum_address for n in all_known_nodes]) |
Contributor
There was a problem hiding this comment.
I think, [ and ] are not necessary here
Contributor
Author
There was a problem hiding this comment.
Indeed; good catch. I will include this change in #1881.
michwill
reviewed
Apr 19, 2020
|
|
||
| # However, it learned about *all* of the nodes in its own domain. | ||
| assert set(first_domain_learners).intersection(set(new_first_domain_learner.known_nodes)) == first_domain_learners | ||
| assert set(first_domain_learners).intersection(set(n.mature() for n in new_first_domain_learner.known_nodes)) == first_domain_learners |
Contributor
There was a problem hiding this comment.
Curiously, it works as .intersection(n.mature() for n in new_first_domain_learner.known_nodes), too
Contributor
Author
There was a problem hiding this comment.
Interesting - that's unexpected. But very nice. I will also include this in #1881.
jMyles
added a commit
that referenced
this pull request
Apr 21, 2020
cygnusv
pushed a commit
to cygnusv/nucypher
that referenced
this pull request
Sep 8, 2020
cygnusv
pushed a commit
to cygnusv/nucypher
that referenced
this pull request
Sep 14, 2020
cygnusv
pushed a commit
to cygnusv/nucypher
that referenced
this pull request
Sep 16, 2020
cygnusv
pushed a commit
to cygnusv/nucypher
that referenced
this pull request
Sep 20, 2020
KPrasch
pushed a commit
to KPrasch/nucypher
that referenced
this pull request
Sep 21, 2020
cygnusv
pushed a commit
that referenced
this pull request
Sep 22, 2020
cygnusv
pushed a commit
that referenced
this pull request
Sep 23, 2020
cygnusv
pushed a commit
that referenced
this pull request
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A precursor to #1881, this PR integrates the changes in nucypher/bytestringSplitter#27.