Conversation
a327baa to
12fb9f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1330 +/- ##
=========================================
- Coverage 84.36% 83.27% -1.1%
=========================================
Files 72 72
Lines 11225 10592 -633
=========================================
- Hits 9470 8820 -650
- Misses 1755 1772 +17
Continue to review full report at Codecov.
|
cygnusv
reviewed
Nov 27, 2019
nucypher/characters/lawful.py
Outdated
| "Bob doesn't have a TreasureMap to match any of these capsules: {}".format( | ||
| capsules)) | ||
|
|
||
| for node_id, arrangement_id in treasure_map_to_use: |
Member
There was a problem hiding this comment.
Can you add this commit (a7d9d7c) to the EPIC? It seems this is a good scope for it.
Member
There was a problem hiding this comment.
Can you add this commit (a7d9d7c) to the EPIC? It seems this is a good scope for it.
Bumping this message again.
Member
There was a problem hiding this comment.
✔️ - cherry picked the commit on top.
19e2bf8 to
c7ee2e1
Compare
b6e6fce to
5587b37
Compare
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Feb 10, 2020
Member
|
@cygnusv - I addressed several of your RFCs. |
…er changes are just code org.
…zzare state, but not impossible in our current logic).
…re Exception than NotEnoughUrsulas: introducing TreasureMap.IsDisorienting
…arts with the first message.
…aps being passed through Bob's controller.
jMyles
pushed a commit
that referenced
this pull request
Feb 10, 2020
cygnusv
approved these changes
Feb 10, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Bob's adventure is now consistent with the assumptions throughout much of the rest of the codebase. Specifically, in a single adventure: Bob can retrieve messages in any number of capsules, he can leave CFrags attached to Capsules either after activation or after an adventure that does not result in activation, and he can save WorkOrders in a replete form, both with completion metadata and the CFrag attached.
Multiple Capsule adventure
retrievenow takes*message_kitsand accounts forBobadventuring with multiplecapsules.TreasureMap).The "KMS" use case
Advanced but not closed:
New issues:
** Note: This branch was previously based on a WIP variant of #1555 - for that history, see d8aebfd.
** Note: This branch also previously included the supermariobox demo, which was initially removed here, but has since been pulled out. For the history including the mariobox, see 93fa937. To add mariobox to a future branch, consider
git cherry-pick 3ba48e14d9bd52e89733262a1721ebe84a6e5c38..56b4b1c3e1f0c76a4da221105b81273b7f6f4c67.