[EPIC] Biznaga: Integration of testnet with staking contracts by cygnusv · Pull Request #1327 · nucypher/nucypher

cygnusv · 2019-09-13T14:41:49Z

Goals:

Integration of UserEscrow staking with the CLI
Renaming of UserEscrow, UserEscrowProxy and UserEscrowLibraryLinker (see Is UserEscrowProxy a good name? #1110)
Improvement of UX of allocation process

Ramp:

Fixes:

Chaperone: @cygnusv

codecov · 2019-09-13T14:42:10Z

Codecov Report

Merging #1327 into master will increase coverage by 0.11%.
The diff coverage is 84.52%.

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
+ Coverage   83.84%   83.96%   +0.11%     
==========================================
  Files          72       72              
  Lines       10829    11170     +341     
==========================================
+ Hits         9080     9379     +299     
- Misses       1749     1791      +42

Impacted Files	Coverage Δ
nucypher/characters/control/emitters.py	`90% <ø> (ø)`	⬆️
nucypher/blockchain/eth/interfaces.py	`71.04% <100%> (+0.31%)`	⬆️
nucypher/blockchain/eth/constants.py	`100% <100%> (ø)`	⬆️
nucypher/blockchain/eth/utils.py	`67.39% <100%> (+4.89%)`	⬆️
nucypher/blockchain/eth/token.py	`89.92% <100%> (+0.24%)`	⬆️
nucypher/blockchain/eth/decorators.py	`91.07% <100%> (+16.07%)`	⬆️
nucypher/utilities/sandbox/constants.py	`98.43% <100%> (+0.02%)`	⬆️
nucypher/blockchain/eth/clients.py	`63.66% <12.5%> (-1.15%)`	⬇️
nucypher/cli/actions.py	`74.28% <59.09%> (-0.21%)`	⬇️
nucypher/crypto/powers.py	`92% <60%> (-2.58%)`	⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ec0b6...a2b4cc9. Read the comment docs.

nucypher/blockchain/eth/actors.py

…ficiary()

…r confirmation

…o UE

…, like PolicyManager

…dress". Closes #1084

… and tests

…sanity checks.

Auto-detect HW accounts in TransactingPower. Finalize basic staking via contract CLI functionality.

Fix conflicts in nucypher stake and nucypher-deploy

mswilkison

lgtm

docs/source/architecture/contracts.md

nucypher/blockchain/eth/deployers.py

nucypher/blockchain/eth/registry.py

nucypher/cli/painting.py

nucypher/blockchain/eth/registry.py

nucypher/cli/characters/stake.py

derekpierre · 2019-10-23T18:35:09Z

nucypher/cli/painting.py

+            emitter.echo(row, color='red')
+        emitter.echo('')  # newline
+    elif not active_stakes:
+        emitter.echo(f"There are no active stakes\n")


Just to clarify our logic here - we only log There are no active stakes if there are no active stakes AND paint_inactive is false.

If there are no active stakes but paint_inactive is true, then we don't log?

L420 loops over non-active stakes. So if paint_inactive is True then it prints any existing non-active stake.

Apologies if I'm missing something here.

Is it the case that the stakes parameter always has at least one stake in it? If stakes is empty, but paint_inactive is True, we will print the following:

========= Inactive Stakes ============ <---- headers-----> ------|-------| ....

with no stakes listed, correct? So we show empty Inactive Stakes titled section?

Ah I see. Well, we have an open issue for this command option (#1436), we can rethink this there.

Co-Authored-By: MacLane S Wilkison <maclane@nucypher.com> Co-Authored-By: Derek Pierre <derek.pierre@gmail.com>

tuxxy · 2019-10-25T21:47:39Z

nucypher/network/nodes.py

+        staking_agent = ContractAgency.get_agent(StakingEscrowAgent, registry=registry)  # type: StakingEscrowAgent
+
+        try:
+            economics = TokenEconomicsFactory.get_economics(registry=registry)


cygnusv force-pushed the biznaga branch 2 times, most recently from 57d4a15 to b1a0355 Compare September 23, 2019 07:58

cygnusv force-pushed the biznaga branch from b1a0355 to c690642 Compare September 24, 2019 11:31

mswilkison reviewed Sep 26, 2019

View reviewed changes

nucypher/blockchain/eth/actors.py Outdated Show resolved Hide resolved

cygnusv force-pushed the biznaga branch 3 times, most recently from af36d91 to 0df10c3 Compare October 7, 2019 10:07

cygnusv force-pushed the biznaga branch from 0df10c3 to ec58e4b Compare October 15, 2019 19:49

cygnusv added 21 commits October 19, 2019 22:48

Handle receipts in allocation methods, not txhashes. Better log messages

3c0d542

Use @validate_checksum_address in UserEscrowProxyDeployer.assign_bene…

5a26441

…ficiary()

Paint allocation data prior deploying UserEscrow contracts and ask fo…

6a25460

…r confirmation

Allow empty message in StdoutEmitter.echo()

5fbcdfd

First version of interactive and verbose allocation deployment

8e479b0

Paint deployed allocations after nucypher-deploy allocations

7c8564f

Support optional "names" for allocations

201d08f

Save allocation receipts after deployment

c98c1ee

Touches to allocation tests

137db28

Touches to nucypher-deploy

aed5d14

Addressing RFCs: better exception and log messages, painting, etc.

91700ab

Minor touches to UserEscrowAgent

66efc2a

Allow Staker to interact with UserEscrow. First pass on entrypoints t…

ea2ded8

…o UE

Allow UserEscrow.withdrawPolicyReward() to accept a recipient address…

0e4e32c

…, like PolicyManager

@validate_checksum_address now checks all parameters ending with "_ad…

08c2f45

…dress". Closes #1084

Improve regex in test_status. Solve pytest regex warnings.

b726b8c

Relocate deposit() from Stake to Staker

01c8bd3

Staker now can deposit tokens on behalf of an allocation user

78b0c57

Add helper function to AllocationRegistry to check if beneficiary is in

58b4b55

Updates to Staker and StakeHolder to support staking via contracts

f552d9c

First pass at creating stakes as an allocation user. Missing painting…

91102b8

… and tests

cygnusv added 4 commits October 19, 2019 23:59

Optionally paint inactive stakes too with nucypher stake list --all

e4dee87

RFCs to PR #1402 (vol 2)

c157a51

Improve clarity of IndividualAllocation template parsing. Additional …

d2de49c

…sanity checks.

Merge pull request #1402 from cygnusv/allocation-registry

a4b32c0

Auto-detect HW accounts in TransactingPower. Finalize basic staking via contract CLI functionality.

cygnusv changed the title ~~[WIP][EPIC] Biznaga: Integration of testnet with staking contracts~~ [EPIC] Biznaga: Integration of testnet with staking contracts Oct 22, 2019

cygnusv marked this pull request as ready for review October 22, 2019 13:06

Merge remote-tracking branch 'upstream/master' into biznaga

e124fe5

Fix conflicts in nucypher stake and nucypher-deploy

mswilkison approved these changes Oct 22, 2019

View reviewed changes

docs/source/architecture/contracts.md Outdated Show resolved Hide resolved

nucypher/blockchain/eth/deployers.py Outdated Show resolved Hide resolved

nucypher/blockchain/eth/registry.py Outdated Show resolved Hide resolved

nucypher/cli/painting.py Show resolved Hide resolved

derekpierre reviewed Oct 23, 2019

View reviewed changes

cygnusv requested review from arjunhassard, derekpierre, fjarri, jMyles, michwill, ravital, tuxxy, vepkenez and vzotova October 23, 2019 19:45

cygnusv force-pushed the biznaga branch from 46f7653 to 6af6fc7 Compare October 23, 2019 20:05

Apply suggestions from code review

a2b4cc9

Co-Authored-By: MacLane S Wilkison <maclane@nucypher.com> Co-Authored-By: Derek Pierre <derek.pierre@gmail.com>

cygnusv force-pushed the biznaga branch from 6af6fc7 to a2b4cc9 Compare October 23, 2019 20:06

derekpierre approved these changes Oct 23, 2019

View reviewed changes

mswilkison added this to the Incentivized Testnet milestone Oct 24, 2019

vzotova mentioned this pull request Oct 24, 2019

WorkLock updates #1407

Merged

vepkenez approved these changes Oct 25, 2019

View reviewed changes

tuxxy approved these changes Oct 25, 2019

View reviewed changes

michwill approved these changes Oct 25, 2019

View reviewed changes

KPrasch approved these changes Oct 25, 2019

View reviewed changes

KPrasch merged commit 88d5d38 into master Oct 25, 2019

jMyles deleted the biznaga branch February 24, 2020 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EPIC] Biznaga: Integration of testnet with staking contracts#1327

[EPIC] Biznaga: Integration of testnet with staking contracts#1327
KPrasch merged 67 commits intomasterfrom
biznaga

cygnusv commented Sep 13, 2019 •

edited

Loading

Uh oh!

codecov bot commented Sep 13, 2019 •

edited

Loading

Uh oh!

Uh oh!

mswilkison left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

derekpierre Oct 23, 2019

Uh oh!

cygnusv Oct 23, 2019

Uh oh!

derekpierre Oct 23, 2019

Uh oh!

cygnusv Oct 23, 2019 •

edited

Loading

Uh oh!

derekpierre Oct 23, 2019

Uh oh!

tuxxy Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

cygnusv commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mswilkison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

derekpierre Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

cygnusv Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

derekpierre Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

cygnusv Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

derekpierre Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

tuxxy Oct 25, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cygnusv commented Sep 13, 2019 •

edited

Loading

codecov bot commented Sep 13, 2019 •

edited

Loading

cygnusv Oct 23, 2019 •

edited

Loading