Skip to content

UserEscrow refactoring#1421

Merged
cygnusv merged 5 commits intonucypher:biznagafrom
vzotova:user-escrow-refactoring
Oct 19, 2019
Merged

UserEscrow refactoring#1421
cygnusv merged 5 commits intonucypher:biznagafrom
vzotova:user-escrow-refactoring

Conversation

@vzotova
Copy link
Member

@vzotova vzotova commented Oct 17, 2019

@vzotova vzotova changed the title UserEscrow refactoring [WIP] UserEscrow refactoring Oct 17, 2019
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1421 into biznaga will not change coverage.
The diff coverage is 89.53%.

Impacted file tree graph

@@           Coverage Diff            @@
##           biznaga    #1421   +/-   ##
========================================
  Coverage    83.27%   83.27%           
========================================
  Files           72       72           
  Lines        10709    10709           
========================================
  Hits          8918     8918           
  Misses        1791     1791
Impacted Files Coverage Δ
nucypher/blockchain/eth/token.py 89.49% <ø> (ø) ⬆️
nucypher/characters/lawful.py 89.12% <100%> (ø) ⬆️
nucypher/utilities/sandbox/constants.py 98.41% <100%> (ø) ⬆️
nucypher/blockchain/eth/registry.py 79.5% <100%> (ø) ⬆️
nucypher/blockchain/eth/constants.py 100% <100%> (ø) ⬆️
nucypher/blockchain/eth/actors.py 86.41% <79.16%> (ø) ⬆️
nucypher/cli/painting.py 78.54% <88.88%> (ø) ⬆️
nucypher/blockchain/eth/agents.py 90% <91.3%> (ø) ⬆️
nucypher/blockchain/eth/deployers.py 88.42% <95.45%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec58e4b...b71ea04. Read the comment docs.

@vzotova vzotova marked this pull request as ready for review October 17, 2019 15:10
@vzotova vzotova changed the title [WIP] UserEscrow refactoring UserEscrow refactoring Oct 17, 2019
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Copy link
Contributor

@michwill michwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I think, this is just renaming?

@cygnusv cygnusv merged commit 46a1608 into nucypher:biznaga Oct 19, 2019
@vzotova vzotova deleted the user-escrow-refactoring branch November 25, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants