Merged
Conversation
mswilkison
reviewed
Aug 16, 2019
Codecov Report
@@ Coverage Diff @@
## biznaga #1227 +/- ##
===========================================
+ Coverage 81.39% 82.76% +1.37%
===========================================
Files 72 72
Lines 10522 10670 +148
===========================================
+ Hits 8564 8831 +267
+ Misses 1958 1839 -119
Continue to review full report at Codecov.
|
73a615b to
0efaef4
Compare
4 tasks
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Sep 17, 2019
Co-authored-by: David Núñez <david@nucypher.com>
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Sep 17, 2019
Co-authored-by: David Núñez <david@nucypher.com>
Merged
mswilkison
approved these changes
Sep 27, 2019
Member
mswilkison
left a comment
There was a problem hiding this comment.
Approving since it technically works :) with the caveat that there are UX/docs difficulties and some bugs as we discussed in Discord.
…, like PolicyManager
* Based on tests/cli/ursula/test_stakeholder_and_ursula.py
derekpierre
approved these changes
Oct 2, 2019
Member
There was a problem hiding this comment.
@cygnusv Approved but just a friendly reminder about the comments regarding removal of the validate_checksum_address check in 3 places in agents.py - 🙂
Member
Author
|
@derekpierre sure, they're in the rebased Branch, not pushed yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to integrate UserEscrow with CLI staking (Closes #856)
Instructions:
Create a stake
See the staking guide for more information.
Notes
UserEscrowProxydeployment with the option--registry-filepath PATH.nucypher-deploy allocations#1319 .Other:
UserEscrowProxy:UserEscrowProxythat preventedUserEscrowcontracts from staking all their tokenswithdrawPolicyReward()wrt to thewithdraw()method inPolicyManager@validate_checksum_addressdecorator: now it validates all arguments ending with_address(e.g,staker_address,worker_address, etc.)