Merged
Conversation
KPrasch
reviewed
Jun 27, 2019
| from nucypher.blockchain.eth.registry import InMemoryEthereumContractRegistry, InMemoryAllocationRegistry | ||
| from nucypher.blockchain.eth.sol.compile import SolidityCompiler | ||
| from nucypher.utilities.sandbox.blockchain import TesterBlockchain | ||
| # Prevents TesterBlockchain to be picked up by py.test as a test class |
Fixing `usefixtures` mark makes it fail due to issue nucypher#1102
* Avoids that unregistered marks just make the test to pass trivially (see https://docs.pytest.org/en/latest/mark.html#raising-errors-on-unknown-marks) * Adds codecov arguments to improve readability of circleci/config.yml
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 68 68
Lines 9081 9081
=======================================
Hits 7561 7561
Misses 1520 1520Continue to review full report at Codecov.
|
KPrasch
approved these changes
Jun 28, 2019
7 tasks
cygnusv
approved these changes
Jun 28, 2019
cygnusv
added a commit
to cygnusv/nucypher
that referenced
this pull request
Jul 1, 2019
cygnusv
added a commit
to cygnusv/nucypher
that referenced
this pull request
Jul 1, 2019
cygnusv
added a commit
to cygnusv/nucypher
that referenced
this pull request
Jul 5, 2019
cygnusv
added a commit
to cygnusv/nucypher
that referenced
this pull request
Jul 9, 2019
cygnusv
added a commit
to cygnusv/nucypher
that referenced
this pull request
Jul 11, 2019
cygnusv
added a commit
to cygnusv/nucypher
that referenced
this pull request
Jul 16, 2019
cygnusv
added a commit
to cygnusv/nucypher
that referenced
this pull request
Jul 17, 2019
KPrasch
pushed a commit
to KPrasch/nucypher
that referenced
this pull request
Jul 18, 2019
KPrasch
pushed a commit
to KPrasch/nucypher
that referenced
this pull request
Jul 18, 2019
KPrasch
pushed a commit
to KPrasch/nucypher
that referenced
this pull request
Jul 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several
py.testwarnings that can obscure real ones from tests.slowmark explicitly inpytest.inipytest.mark.usesfixtures->pytest.mark.usefixtures(this actually makes these tests pass)TesterBlockchainon import in tests to preventpy.testfrom trying to pick it up