-
Notifications
You must be signed in to change notification settings - Fork 277
Closed
Labels
Is this done?Ambiguous closing requirements may already be metAmbiguous closing requirements may already be metTest 🔍Tests onlyTests only
Milestone
Description
Some of our deployer and actor tests are very poor (or not exisiting). It's not a very pressing need since we already test everything at the CLI, contract and agent layers, but still...
Actors:
Unit tests for:
-
Worker -
Investigator -
NucypherTokenActor. - Unit tests for
PolicyAuthoractor are very small.
Deployers:
- Test
test_user_escrow_deployer.py::test_deploy_multiple()needs a fix and it's currently skipped (see Fixpy.testwarnings #1106). - In
PolicyManagerDeployer, check that StakingEscrow contract address and public parameters are correct - In
StakingEscrowDeployer, check that token contract address and staking parameters are correct.
I'm working on this in a post-alhambra-verde PR (#1111)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Is this done?Ambiguous closing requirements may already be metAmbiguous closing requirements may already be metTest 🔍Tests onlyTests only