Skip to content

Better tests for Deployers and Actors #1102

@cygnusv

Description

@cygnusv

Some of our deployer and actor tests are very poor (or not exisiting). It's not a very pressing need since we already test everything at the CLI, contract and agent layers, but still...

Actors:
Unit tests for:

  • Worker
  • Investigator
  • NucypherTokenActor.
  • Unit tests for PolicyAuthor actor are very small.

Deployers:

  • Test test_user_escrow_deployer.py::test_deploy_multiple() needs a fix and it's currently skipped (see Fix py.test warnings #1106).
  • In PolicyManagerDeployer, check that StakingEscrow contract address and public parameters are correct
  • In StakingEscrowDeployer, check that token contract address and staking parameters are correct.

I'm working on this in a post-alhambra-verde PR (#1111)

Metadata

Metadata

Assignees

Labels

Is this done?Ambiguous closing requirements may already be metTest 🔍Tests only

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions