Decentralized Identity Verification Fixes and Naming#1048
Merged
cygnusv merged 3 commits intonucypher:hawksbeardfrom Jun 5, 2019
Merged
Decentralized Identity Verification Fixes and Naming#1048cygnusv merged 3 commits intonucypher:hawksbeardfrom
cygnusv merged 3 commits intonucypher:hawksbeardfrom
Conversation
…on/Validation naming clarifications, Code cleanup and style fixes for signature flow.
…alidNode exception subclasses for logging
Codecov Report
@@ Coverage Diff @@
## hawksbeard #1048 +/- ##
==============================================
+ Coverage 83.1% 83.19% +0.08%
==============================================
Files 67 67
Lines 8656 8663 +7
==============================================
+ Hits 7194 7207 +13
+ Misses 1462 1456 -6
Continue to review full report at Codecov.
|
fjarri
reviewed
Jun 4, 2019
cygnusv
requested changes
Jun 5, 2019
Member
cygnusv
left a comment
There was a problem hiding this comment.
Overall, all good :) Just some minor comments and RFCs
cygnusv
approved these changes
Jun 5, 2019
jMyles
reviewed
Jun 5, 2019
| self.__decentralized_identity_evidence = constant_or_bytes(decentralized_identity_evidence) | ||
|
|
||
| # Assume unverified | ||
| self.verified_stamp = False |
Contributor
There was a problem hiding this comment.
Why move these settings to __init__? Doesn't this pattern just put more bloat in __init__?
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1044, Needs follow up post #1029 as part of #1003