-
Notifications
You must be signed in to change notification settings - Fork 277
Closed
Labels
Bug 🐛Broken functionalityBroken functionality
Description
Weird things that were merged too fast with #1040:
- What happens if
self.federated_onlyandself._identity_evidence is NOT_SIGNED? Currently, the method simply finishes without returning a value (hence, returningNone). - The logic for decentralized validation is the following:
# Off-chain signature verification
if self._stamp_has_valid_wallet_signature():
self.verified_stamp = True
return True
# On-chain staking check
if verify_staking:
self._is_valid_worker()It seems that the on-chain checks are never hit when self._stamp_has_valid_wallet_signature(), since it returns True. Or conversely, the only way to do the on-chain check is to fail the stamp's signature verification, which is wrong.
In any case, I'm working in #1033 in alhambra-verde and I'll fix this too.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Bug 🐛Broken functionalityBroken functionality