Intermode node verification support#1040
Merged
KPrasch merged 1 commit intonucypher:hawksbeardfrom Jun 3, 2019
Merged
Conversation
…dible with federated nodes
KPrasch
commented
Jun 3, 2019
| from constant_sorrow import constants | ||
| from cryptography import x509 | ||
| from cryptography.exceptions import InvalidSignature # TODO: Use nucypher exceptions | ||
| from cryptography.exceptions import InvalidSignature |
Member
Author
There was a problem hiding this comment.
Im getting a circular dependency when trying to import from nucypher.crypto.signing - Unsure how to proceed exactly
Contributor
There was a problem hiding this comment.
Hmmm, tough one. Can't import it in the spot you want to raise specifically?
tuxxy
approved these changes
Jun 3, 2019
| version = self.TEACHER_VERSION.to_bytes(2, "big") | ||
| interface_info = VariableLengthBytestring(bytes(self.rest_information()[0])) | ||
| identity_evidence = VariableLengthBytestring(self._evidence_of_decentralized_identity) | ||
| identity_evidence = VariableLengthBytestring(self._identity_evidence) |
| # Offline check of valid stamp signature by worker | ||
| try: | ||
| self.stamp_is_valid() | ||
| self.stamp_is_valid(verify_staking=verify_staking) |
Codecov Report
@@ Coverage Diff @@
## hawksbeard #1040 +/- ##
==============================================
- Coverage 83.2% 82.98% -0.23%
==============================================
Files 67 67
Lines 8658 8656 -2
==============================================
- Hits 7204 7183 -21
- Misses 1454 1473 +19
Continue to review full report at Codecov.
|
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some careful handling of node verification and staking checks during intermode learning.