Skip to content

Howdy, Staker!#1023

Merged
KPrasch merged 3 commits intonucypher:alhambra-verdefrom
KPrasch:howdy-staker
May 30, 2019
Merged

Howdy, Staker!#1023
KPrasch merged 3 commits intonucypher:alhambra-verdefrom
KPrasch:howdy-staker

Conversation

@KPrasch
Copy link
Member

@KPrasch KPrasch commented May 29, 2019

Based on #1020 -> #949

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1023 into alhambra-verde will increase coverage by 0.07%.
The diff coverage is 85.81%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           alhambra-verde    #1023      +/-   ##
==================================================
+ Coverage           84.98%   85.05%   +0.07%     
==================================================
  Files                  65       65              
  Lines                7908     7925      +17     
==================================================
+ Hits                 6721     6741      +20     
+ Misses               1187     1184       -3
Impacted Files Coverage Δ
nucypher/policy/models.py 92.19% <ø> (ø) ⬆️
nucypher/utilities/sandbox/blockchain.py 90.97% <0%> (ø) ⬆️
nucypher/characters/lawful.py 89.14% <100%> (ø) ⬆️
nucypher/blockchain/eth/deployers.py 91.87% <100%> (ø) ⬆️
nucypher/utilities/sandbox/ursula.py 98.27% <100%> (+0.06%) ⬆️
nucypher/cli/deploy.py 81.05% <100%> (ø) ⬆️
nucypher/blockchain/eth/token.py 89.78% <100%> (ø) ⬆️
nucypher/blockchain/economics.py 100% <100%> (ø) ⬆️
nucypher/config/node.py 84.54% <100%> (ø) ⬆️
nucypher/cli/config.py 93.9% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f558e2f...0042c40. Read the comment docs.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1023 into alhambra-verde will increase coverage by 17.51%.
The diff coverage is 83.96%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           alhambra-verde    #1023       +/-   ##
===================================================
+ Coverage           67.54%   85.05%   +17.51%     
===================================================
  Files                  65       65               
  Lines                7925     7925               
===================================================
+ Hits                 5353     6741     +1388     
+ Misses               2572     1184     -1388
Impacted Files Coverage Δ
nucypher/policy/models.py 92.19% <ø> (+1.73%) ⬆️
nucypher/utilities/sandbox/blockchain.py 90.97% <0%> (+23.3%) ⬆️
nucypher/blockchain/eth/token.py 89.78% <100%> (+51.07%) ⬆️
nucypher/config/node.py 84.54% <100%> (+9.09%) ⬆️
nucypher/blockchain/eth/deployers.py 91.87% <100%> (+48.76%) ⬆️
nucypher/cli/deploy.py 81.05% <100%> (+52.63%) ⬆️
nucypher/characters/lawful.py 89.14% <100%> (+4.95%) ⬆️
nucypher/cli/config.py 93.9% <100%> (+24.39%) ⬆️
nucypher/cli/characters/ursula.py 75.4% <33.33%> (+25.66%) ⬆️
nucypher/blockchain/eth/policies.py 59.2% <42.85%> (+59.2%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f2f6e...a3e317d. Read the comment docs.

@KPrasch KPrasch marked this pull request as ready for review May 30, 2019 09:40
@KPrasch KPrasch requested review from cygnusv, tuxxy and vzotova May 30, 2019 09:40
@KPrasch KPrasch merged commit 9b06a10 into nucypher:alhambra-verde May 30, 2019
cygnusv pushed a commit to cygnusv/nucypher that referenced this pull request Jun 4, 2019
@KPrasch KPrasch deleted the howdy-staker branch July 21, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants